lint audit: Implementation + move one lint #2579
Conversation
|
LGTM. There are a bunch of cases where I think another category may also apply; but it's up to you if we should choose that instead. Unsure which. |
| pub DOUBLE_PARENS, Warn, | ||
| declare_clippy_lint! { | ||
| pub DOUBLE_PARENS, | ||
| complexity, |
Manishearth
Mar 29, 2018
Member
perhaps style? idk. complexity makes sense too
perhaps style? idk. complexity makes sense too
oli-obk
Mar 29, 2018
Author
Collaborator
My idea of complexity is anything that makes the code look more complex than it is, and everyone can agree that it should be improved. It's a fuzzy boundary, but I want to keep complexity lints as lints that no matter of personal style references, everyone wants to make those changes.
My idea of complexity is anything that makes the code look more complex than it is, and everyone can agree that it should be improved. It's a fuzzy boundary, but I want to keep complexity lints as lints that no matter of personal style references, everyone wants to make those changes.
Manishearth
Mar 29, 2018
Member
ah, that's a reasonable boundary, makes sense
ah, that's a reasonable boundary, makes sense
| @@ -22,9 +22,9 @@ use utils::{camel_case_from, camel_case_until, in_macro}; | |||
| /// HummingbirdCake, | |||
| /// } | |||
| /// ``` | |||
| declare_lint! { | |||
| declare_clippy_lint! { | |||
Manishearth
Mar 29, 2018
Member
While we're here, we should document it such that the difference between the two is obvious
While we're here, we should document it such that the difference between the two is obvious
oli-obk
Mar 29, 2018
Author
Collaborator
done
done
| pub FALLIBLE_IMPL_FROM, Allow, | ||
| declare_clippy_lint! { | ||
| pub FALLIBLE_IMPL_FROM, | ||
| nursery, |
Manishearth
Mar 29, 2018
Member
should this still be nursery?
(did TryFrom stabilize?)
should this still be nursery?
(did TryFrom stabilize?)
oli-obk
Mar 29, 2018
Author
Collaborator
I don't think it stabilized
I don't think it stabilized
Manishearth
Mar 29, 2018
Member
belongs in the nursery then, yes? It's allow because we don't want to make it warn yet, not because we don't want to make it warn ever
belongs in the nursery then, yes? It's allow because we don't want to make it warn yet, not because we don't want to make it warn ever
| pub POSSIBLE_MISSING_COMMA, | ||
| Warn, | ||
| style, |
Manishearth
Mar 29, 2018
Member
correctness?
correctness?
| pub TOO_MANY_ARGUMENTS, | ||
| Warn, | ||
| style, |
Manishearth
Mar 29, 2018
Member
perhaps also complexity? idk
perhaps also complexity? idk
oli-obk
Mar 29, 2018
Author
Collaborator
neither do I, I'll put it there, if ppl complain we can put it back.
neither do I, I'll put it there, if ppl complain we can put it back.
| pub BOOL_COMPARISON, | ||
| Warn, | ||
| style, |
Manishearth
Mar 29, 2018
Member
complexity?
complexity?
| pub PRINTLN_EMPTY_STRING, | ||
| Warn, | ||
| style, |
Manishearth
Mar 29, 2018
Member
the lint description here is incorrect
the lint description here is incorrect
| pub BOX_VEC, | ||
| Warn, | ||
| complexity, |
Manishearth
Mar 29, 2018
Member
perf?
perf?
oli-obk
Mar 29, 2018
Author
Collaborator
both ^^ it's not just slower or requires more memory, it's just weird
both ^^ it's not just slower or requires more memory, it's just weird
| pub LINT_AUTHOR, | ||
| Warn, | ||
| style, // ok, this is not a style lint, but it's also a noop without the appropriate attribute |
Manishearth
Mar 29, 2018
Member
Can we keep it in the nursery or internal instead?
Can we keep it in the nursery or internal instead?
| pub DEEP_CODE_INSPECTION, | ||
| Warn, | ||
| style, // not a style lint, but essentially a noop without the appropriate attribute |
Manishearth
Mar 29, 2018
Member
ditto wrt nursery
ditto wrt nursery
I still need to figure out how to make
warn(clippy)causewarn(clippy_style, clippy_perf, ...)