Skip to content

/ rust-clippy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CONTRIBUTING.md #2606

Merged
merged 1 commit into from Apr 1, 2018
Merged

Improve CONTRIBUTING.md #2606

merged 1 commit into from Apr 1, 2018

Conversation

@phansch
Copy link
Member

@phansch phansch commented Apr 1, 2018 •
edited

Made some small improvements to the contribution instructions:

  • Incremental compilation is on by default since Rust 1.24
  • Restructured the label overview to go from easy to more difficult labels

Rendered before | Rendered after
@phansch
Improve CONTRIBUTING.md
Unverified
The key that signed this is expired.
GPG key ID: 93FB33459D311E5E Learn about signing commits
Loading status checks…
872db02 
* Incremental compilation is on by default
* Restructured the label overview to go from easy to more difficult labels.
@mcarton
Copy link
Member

@mcarton mcarton commented Apr 1, 2018

Thanks!

Rendered before | Rendered after

You can ask GitHub to display a rich diff: https://github.com/rust-lang-nursery/rust-clippy/pull/2606/files?short_path=6a33714#diff-6a3371457528722a734f3c51d9238c13
@mcarton mcarton merged commit 83e2109 into rust-lang:master Apr 1, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phansch phansch deleted the phansch:improve_contributing_instructions branch Apr 1, 2018
@phansch
Copy link
Member Author

@phansch phansch commented Apr 1, 2018

You can ask GitHub to display a rich diff: https://github.com/rust-lang-nursery/rust-clippy/pull/2606/files?short_path=6a33714#diff-6a3371457528722a734f3c51d9238c13

ohh nice, good to know!
@phansch phansch mentioned this pull request Apr 13, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@phansch @mcarton