Fix nonminimal_bool false positive #2644

phansch · 2018-04-07T10:54:15Z

It was checking any is_ok, is_err, is_some, is_none method for negation
but it should only perform the check for the built-in types Option and Result, not custom
types.

Fixes #2638

It was checking any is_ok, is_err, is_some, is_none method for negation but it should only perform the check for the built-in types, not custom types.

Fix nonminimal_bool false positive

90e7d93

It was checking any is_ok, is_err, is_some, is_none method for negation but it should only perform the check for the built-in types, not custom types.

oli-obk merged commit 22df45f into rust-lang:master Apr 7, 2018

phansch deleted the fix_nonminimal_bool_false_positive branch April 7, 2018 11:19

Fix nonminimal_bool false positive #2644

Fix nonminimal_bool false positive #2644

Conversation

phansch commented Apr 7, 2018 • edited

phansch commented Apr 7, 2018 •

edited