Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nonminimal_bool false positive #2644

Merged

Conversation

@phansch
Copy link
Member

@phansch phansch commented Apr 7, 2018

It was checking any is_ok, is_err, is_some, is_none method for negation
but it should only perform the check for the built-in types Option and Result, not custom
types.

Fixes #2638

It was checking any is_ok, is_err, is_some, is_none method for negation
but it should only perform the check for the built-in types, not custom
types.
@oli-obk oli-obk merged commit 22df45f into rust-lang:master Apr 7, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@phansch phansch deleted the phansch:fix_nonminimal_bool_false_positive branch Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants