Explain how Clippy and lints work #2687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be good if someone with more experience has a look at this, as I'm not sure if I used the correct terms everywhere. |
Manishearth
approved these changes
Apr 21, 2018
| reg.register_early_lint_pass(box else_if_without_else::ElseIfWithoutElse); | ||
| // ... | ||
|
|
||
| reg.register_lint_group("clippy_restriction", vec
There was a problem hiding this comment.
The util/update_lints.py script looks through the sources and collects all lint definitions to generate this part of lib.rs.
There was a problem hiding this comment.
oh, that kind of autogenerated! I've always been modifying it manually until now.. Makes sense to add it 👍
|
I added the note about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also for #2666
This adds a rough overview of how Clippy hooks into rustc and how different lint types are registered with the PluginRegistry. It doesn't explain everything yet, but should give a good overview, hopefully.
It is partly inspired by the quick rustfmt tour.
Rendered