New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup to latest nightly #2703

Merged
merged 1 commit into from Apr 28, 2018

Conversation

Projects
None yet
3 participants
@phansch
Collaborator

phansch commented Apr 28, 2018

@oli-obk oli-obk merged commit 1742229 into rust-lang:master Apr 28, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:rustup20180427 branch Apr 28, 2018

@@ -302,7 +302,7 @@ pub fn implements_trait<'a, 'tcx>(
cx.tcx
.predicate_for_trait_def(cx.param_env, traits::ObligationCause::dummy(), trait_id, 0, ty, ty_params);
cx.tcx.infer_ctxt().enter(|infcx| {
traits::SelectionContext::new(&infcx).evaluate_obligation_conservatively(&obligation)
traits::SelectionContext::new(&infcx).infcx().predicate_must_hold(&obligation)

This comment has been minimized.

@aravind-pg

aravind-pg Apr 30, 2018

Sorry, didn't see this PR earlier but this could just be infcx.predicate_must_hold(...) --- i.e., no need to create a SelectionContext. No functional difference though, and I suppose not much perf difference in practice either, so not a big deal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment