Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upRustup to latest nightly #2703
Conversation
oli-obk
merged commit 1742229
into
rust-lang:master
Apr 28, 2018
phansch
deleted the
phansch:rustup20180427
branch
Apr 28, 2018
| @@ -302,7 +302,7 @@ pub fn implements_trait<'a, 'tcx>( | ||
| cx.tcx | ||
| .predicate_for_trait_def(cx.param_env, traits::ObligationCause::dummy(), trait_id, 0, ty, ty_params); | ||
| cx.tcx.infer_ctxt().enter(|infcx| { | ||
| traits::SelectionContext::new(&infcx).evaluate_obligation_conservatively(&obligation) | ||
| traits::SelectionContext::new(&infcx).infcx().predicate_must_hold(&obligation) |
This comment has been minimized.
This comment has been minimized.
aravind-pg
Apr 30, 2018
Sorry, didn't see this PR earlier but this could just be infcx.predicate_must_hold(...) --- i.e., no need to create a SelectionContext. No functional difference though, and I suppose not much perf difference in practice either, so not a big deal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
phansch commentedApr 28, 2018
Due to rust-lang/rust#48995 and rust-lang/rust#49894