Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upConversation
This comment has been minimized.
This comment has been minimized.
Oh, it's in a different body table because it's a constant ;). The expression variant (ExprRepeat) has a field of type BodyId. Try calling |
phansch
referenced this pull request
May 16, 2018
Closed
clippy triggers ICE: librustc/ty/context.rs:527: node_id_to_type: no type for node `expr 10 (id=678)` #2767
This comment has been minimized.
This comment has been minimized.
|
Thanks! The code slowly starts to make sense to me 8fdf2a8#diff-facf8838686f92b7be75999cfbe7e987R493 fixes the SpanlessHash ICE. However it feels not correct to me, because it will set the table to the table of the constant for the following iterations, which could potentially cause other lookup issues. And actually it does change the debug output for |
| @@ -490,6 +490,7 @@ impl<'a, 'tcx: 'a> SpanlessHash<'a, 'tcx> { | ||
| let c: fn(_, _) -> _ = ExprRepeat; | ||
| c.hash(&mut self.s); | ||
| self.hash_expr(e); | ||
| self.tables = self.cx.tcx.body_tables(l_id); | ||
| self.hash_expr(&self.cx.tcx.hir.body(l_id).value); |
This comment has been minimized.
This comment has been minimized.
oli-obk
May 17, 2018
Collaborator
You can store the old tables in a temporary variable and restore them afterwards. This is essentially how rustc does it for LateContext. We should probably abstract that feature in some generic form so all the cases where we or rustc do it can be made correct in a way that can't be accidentally forgotten.
phansch
force-pushed the
phansch:tasty_ice_cream
branch
2 times, most recently
from
1d0105e
to
a9e09ba
May 17, 2018
phansch
force-pushed the
phansch:tasty_ice_cream
branch
3 times, most recently
from
c473221
to
cb2f507
May 17, 2018
phansch
changed the title from
[wip] Fix SpanlessHash and SpanlessEq tables
to
Fix SpanlessHash and SpanlessEq tables
May 17, 2018
phansch
force-pushed the
phansch:tasty_ice_cream
branch
from
cb2f507
to
373033e
May 17, 2018
phansch
added some commits
May 13, 2018
phansch
force-pushed the
phansch:tasty_ice_cream
branch
from
373033e
to
ed885dc
May 17, 2018
This comment has been minimized.
This comment has been minimized.
|
Ok, I think this is ready for review @oli-obk |
oli-obk
merged commit dc5a5a4
into
rust-lang:master
May 18, 2018
This comment has been minimized.
This comment has been minimized.
Ameobea
commented
May 18, 2018
|
Thanks very much for this! |
phansch commentedMay 15, 2018
•
edited
This makes sure the correct tables are used for constant lookup around
SpanlessHashandSpanlessEqFixes #2767
Fixes #2594
Fixes #2499
Closes #1783
Fixes #1782