Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further automate pre_publish.sh #2962

Merged
merged 2 commits into from Aug 30, 2018

Conversation

phansch
Copy link
Member

@phansch phansch commented Jul 25, 2018

The script now runs the tests after cargo fmt.

@Manishearth
Copy link
Member

Are we running this at all now given that we distribute clippy with rustc?

I was going to suggest replacing the published clippy with a no-op crate that tells you to install clippy the real way via a build script

@phansch
Copy link
Member Author

phansch commented Jul 26, 2018

If we don't release versions or publish git tags anymore, we can change the commit message in this script and remove a few replacements from util/update_lints.py. Apart from that, I think we can continue to use the script in one form or another. It does a lot of things currently:

  1. Some git diffing, which I don't really understand the purpose of
  2. Calls util/update_lints.py which should be used when adding new lints, but sometimes is forgotten/done manually. Running this during publishing just makes sure that the lint counter in the README is correct and that the changelog links are correct. The script..
    1. Updates the lint counter in the README
    2. Updates the hidden changelog lint links at the bottom
    3. Sets the clippy_lints version in Cargo.toml to the clippy version
    4. Inserts missing pub mod lint_name in clippy_lints/src/lib.rs
    5. Adds missing lints to the respective lint groups in clippy_lints/src/lib.rs
  3. It creates a "Bump the version" commit with the above changes
  4. It runs rustfmt
  5. It tells the user a few more manual things to do in preparation for publishing a new release

@oli-obk
Copy link
Contributor

oli-obk commented Aug 7, 2018

The diffing was to ensure that you didn't forget to actually bump the verison or edit the CHANGELOG.

Just remove all that nonsense now ;)

@phansch phansch added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Aug 29, 2018
Because we no bump versions
@phansch
Copy link
Member Author

phansch commented Aug 30, 2018

Removed the git diffing part

@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 30, 2018
@oli-obk oli-obk merged commit d3f78d6 into rust-lang:master Aug 30, 2018
@phansch phansch deleted the further_automate_pre_publish branch August 30, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants