Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup README for clippy-preview on stable #3165

Merged

Conversation

@phansch
Copy link
Member

@phansch phansch commented Sep 11, 2018

With the 1.29 release, the clippy-preview component will be available
on stable which means we don't need nightly/beta anymore.

This also removes the rust-update script which was still using cargo install to install clippy.

Closes #3177

@phansch
Copy link
Member Author

@phansch phansch commented Sep 11, 2018

We can merge this in 2 days with the next stable release 🚀 🎉

README.md Outdated
@@ -54,26 +54,15 @@ rustup and compiler:
rustup update
```

#### Step 2: Install nightly toolchain
#### Step 2: Install clippy

This comment has been minimized.

@mati865

mati865 Sep 11, 2018
Contributor

Pedantic: It's now called Clippy.

@phansch phansch force-pushed the phansch:cleanup_readme_for_clippy_preview_on_stable branch from ac0028e to 009b46b Sep 11, 2018
phansch added 2 commits Sep 11, 2018
With the 1.29 release, the `clippy-preview` component will be available
on stable which means we don't need nightly/beta anymore.
We no longer need this as clippy is installed through rustup now.
@phansch phansch force-pushed the phansch:cleanup_readme_for_clippy_preview_on_stable branch from 009b46b to c42cd60 Sep 13, 2018
@phansch
Copy link
Member Author

@phansch phansch commented Sep 13, 2018

Going to give this a try and then merge 🎈

@phansch phansch merged commit 75111de into rust-lang:master Sep 13, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phansch phansch deleted the phansch:cleanup_readme_for_clippy_preview_on_stable branch Sep 13, 2018
@phansch
Copy link
Member Author

@phansch phansch commented Sep 13, 2018

🎆 🎆 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants