Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'impossible case reached' ICE #3248

Merged
merged 1 commit into from Oct 2, 2018
Merged

Conversation

@phansch
Copy link
Member

@phansch phansch commented Oct 1, 2018

This fixes the ICE by using substs directly and creating the type+lifetime parameter list that way.

@arielb1 Was correct in that input_types drops the lifetime parameters and only keeps the type parameters (nightly docs)

Fixes #2831

@oli-obk oli-obk merged commit 788c838 into rust-lang:master Oct 2, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@phansch phansch deleted the phansch:fix_ice_2831 branch Oct 2, 2018
@oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented Oct 10, 2018

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Oct 10, 2018

link to blog post in the commit message and/or PR body? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants