Fix FP in fn_to_numeric_cast_with_truncation
#3279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth |
phansch
force-pushed
the
fix_fp_in_fn_to_numeric_cast_with_truncation
branch
from
25c632d
to
6bbb11e
Compare
We only want this lint to check casts to numeric, as per the lint title. Rust already has a built-in check for all other casts [here][rust_check]. [rust_check]: https://github.com/rust-lang/rust/blob/5472b0718f286266ab89acdf234c3552de7e973c/src/librustc_typeck/check/cast.rs#L430-L433
phansch
force-pushed
the
fix_fp_in_fn_to_numeric_cast_with_truncation
branch
from
6bbb11e
to
d365742
Compare
|
We don't have bors on this repo |
|
Yea, I just saw https://app.bors.tech/repositories/3993 and was wondering if it was already working. Sorry for the spam ❤️ |
Merged
bors bot
added a commit
that referenced
this pull request
Oct 24, 2018
3348: Setup bors for Clippy r=phansch a=flip1995 Since [bors-ng](https://app.bors.tech/repositories/3993) is already installed for this repo for a while (#3279 (comment)), the only thing missing, before we can use it, is the `bors.toml`. (bors-ng [docs](https://bors.tech/documentation/getting-started/)) If we want to move forward with this and this gets merged, the only thing left to do is to create the branches `staging` and `trying`. @phansch @oli-obk Co-authored-by: flip1995 <hello@philkrones.com> Co-authored-by: Philipp Krones <hello@philkrones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts here.
Fixes #3275