/rust-clippy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FP in `fn_to_numeric_cast_with_truncation` #3279

Merged
merged 1 commit into from Oct 7, 2018

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@phansch @Manishearth
@phansch
Collaborator

phansch commented Oct 7, 2018

We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts here.

Fixes #3275
@phansch

This comment has been minimized.

Sign in to view
Collaborator

phansch commented Oct 7, 2018

r? @Manishearth

@phansch phansch force-pushed the phansch:fix_fp_in_fn_to_numeric_cast_with_truncation branch from 25c632d to 6bbb11e Oct 7, 2018

@phansch
Fix FP in `fn_to_numeric_cast_with_truncation` 
We only want this lint to check casts to numeric, as per the lint title.
Rust already has a built-in check for all other casts
[here][rust_check].

[rust_check]: https://github.com/rust-lang/rust/blob/5472b0718f286266ab89acdf234c3552de7e973c/src/librustc_typeck/check/cast.rs#L430-L433
Verified
This commit was signed with a verified signature.
@phansch phansch Philipp Hansch
GPG key ID: B6FA06A6E0E2665B Learn about signing commits
Loading status checks…
d365742

@phansch phansch force-pushed the phansch:fix_fp_in_fn_to_numeric_cast_with_truncation branch from 6bbb11e to d365742 Oct 7, 2018

@Manishearth

This comment has been minimized.

Sign in to view
Member

Manishearth commented Oct 7, 2018

We don't have bors on this repo

@Manishearth Manishearth merged commit 5dcb90e into rust-lang:master Oct 7, 2018
1 of 2 checks passed

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@phansch phansch deleted the phansch:fix_fp_in_fn_to_numeric_cast_with_truncation branch Oct 7, 2018

@phansch

This comment has been minimized.

Sign in to view
Collaborator

phansch commented Oct 7, 2018

Yea, I just saw https://app.bors.tech/repositories/3993 and was wondering if it was already working. Sorry for the spam ❤️

@flip1995 flip1995 referenced this pull request Oct 22, 2018

Merged

Setup bors for Clippy #3348

bors bot added a commit that referenced this pull request Oct 24, 2018

@bors[bot] @flip1995
Merge #3348 
3348: Setup bors for Clippy r=phansch a=flip1995

Since [bors-ng](https://app.bors.tech/repositories/3993) is already installed for this repo for a while (#3279 (comment)), the only thing missing, before we can use it, is the `bors.toml`. (bors-ng [docs](https://bors.tech/documentation/getting-started/))

If we want to move forward with this and this gets merged, the only thing left to do is to create the branches `staging` and `trying`.

@phansch @oli-obk 

Co-authored-by: flip1995 <hello@philkrones.com>
Co-authored-by: Philipp Krones <hello@philkrones.com>
Loading status checks…
3ff2c1f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment