Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIIR update_lints: Update changelog links #3327

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@phansch
Copy link
Collaborator

phansch commented Oct 17, 2018

This now also updates the link list at the bottom of the changelog.

cc #2882

RIIR update_lints: Update changelog links
This now also updates the link list at the bottom of the changelog.
@@ -59,8 +59,8 @@ fn print_lints() {
}

fn update_lints() {
let lint_list = gather_all();
let usable_lints: Vec<Lint> = Lint::usable_lints(lint_list).collect();
let lint_list: Vec<Lint> = gather_all().collect();

This comment has been minimized.

@phansch

phansch Oct 17, 2018

Author Collaborator

This is now a Vec because the iterator would have been consumed the first time it's used. Now it's cloning the Vec for every replace_region_in_file. Not sure if there's a better way. At least the files are only parsed once.

@oli-obk oli-obk merged commit f40c4fa into rust-lang:master Oct 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:update_changelog_riir branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.