RIIR update lints: Add check mode (update_lints.py rewrite complete) #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
flip1995
reviewed
Nov 4, 2018
oli-obk
approved these changes
Nov 4, 2018
This finishes up the rewrite of `update_lints.py` in Rust. More specifically, this * adds the `--check` flag and handling to clippy_dev * tracks file changes over the different calls to `replace_region_in_file` * only writes changes to files if the `--check` flag is *not* used * runs `./util/dev update_lints --check` on CI instead of the old script * replaces usage of the `update_lints.py` script with an error `./util/dev update_lints` behaves 99% the same as the python script. The only difference that I'm aware of is an ordering change to `clippy_lints/src/lib.rs` because underscores seem to be sorted differently in Rust and in Python. 馃弫
`gen_deprecated` should never have created the string with linebreaks. Using a single string broke the check because the changed lines were different.
Co-Authored-By: phansch <dev@phansch.net>
phansch
force-pushed
the
riir_update_lints_finish_line
branch
from
a67b2ba
to
745a619
Compare
|
bors r+ let's get this show on the road |
bors bot
added a commit
that referenced
this pull request
Nov 5, 2018
3408: RIIR update lints: Add check mode (update_lints.py rewrite complete) r=oli-obk a=phansch This finishes up the rewrite of `update_lints.py` in Rust. More specifically, this * adds the `--check` flag and handling to clippy_dev * tracks file changes over the different calls to `replace_region_in_file` * only writes changes to files if the `--check` flag is *not* used * runs `./util/dev update_lints --check` on CI instead of the old script * replaces usage of the `update_lints.py` script with an error `./util/dev update_lints` behaves 99% the same as the python script. The only difference that I'm aware of is an ordering change to `clippy_lints/src/lib.rs` because underscores seem to be sorted differently in Rust and in Python. 馃弫 cc #2882 Co-authored-by: Philipp Hansch <dev@phansch.net> Co-authored-by: Philipp Krones <hello@philkrones.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finishes up the rewrite of
update_lints.pyin Rust. Morespecifically, this
--checkflag and handling to clippy_devreplace_region_in_file--checkflag is not used./util/dev update_lints --checkon CI instead of the old scriptupdate_lints.pyscript with an error./util/dev update_lintsbehaves 99% the same as the python script.The only difference that I'm aware of is an ordering change to
clippy_lints/src/lib.rsbecause underscores seem to be sorteddifferently in Rust and in Python.
馃弫
cc #2882