New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git: Enforce LF lineendings for everything #3484

Merged
merged 1 commit into from Dec 2, 2018

Conversation

Projects
None yet
2 participants
@phansch
Collaborator

phansch commented Dec 2, 2018

Someone on Discord reported issues with UI tests.

This should make sure that git never automatically converts lineendings
for text files to CRLF. They should always be LF now.

Probably this means that we can stop using dos2unix for #3306, too.

Taken from Rust's .gitattributes file.

Enforce LF lineendings for everything
Someone on discord reported issues with UI tests.

This should make sure that git never automatically converts lineendings
for text files to `CRLF`. They should always be `LF` now.

Probably this means that we can stop using dos2unix for #3306, too.

Taken from [Rust's .gitattributes file](https://github.com/rust-lang/rust/blob/master/.gitattributes).

@phansch phansch merged commit 6253d45 into rust-lang:master Dec 2, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@phansch phansch deleted the phansch:fix_windows_lineendings branch Dec 2, 2018

@phansch

This comment has been minimized.

Collaborator

phansch commented Dec 2, 2018

@daxpedda

This comment has been minimized.

Contributor

daxpedda commented Dec 2, 2018

Thanks for the fast resolution @phansch, it's great when problems can be resolved that fast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment