Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate rustfix into Clippy test suite #3519

Merged
merged 6 commits into from Jan 3, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Dec 9, 2018

Once the PR to compiletest-rs is reviewed and merged this fixes #2376.

I will create a separate tracking issue for adding run-rustfix to all tests.

@phansch
Copy link
Member Author

@phansch phansch commented Dec 9, 2018

It looks like it already found an incorrect suggestion for the unnecessary_ref lint 😄

@phansch
Copy link
Member Author

@phansch phansch commented Dec 9, 2018

@bors hello?

@bors
Copy link
Contributor

@bors bors commented Dec 9, 2018

😪 I'm awake I'm awake

@phansch phansch changed the title WIP: Integrate rustfix into Clippy test suite Integrate rustfix into Clippy test suite Dec 10, 2018
@bors

This comment has been hidden.

@phansch phansch force-pushed the phansch:brave_newer_ui_tests branch from bf6792b to 3270724 Dec 12, 2018
Copy link
Member

@flip1995 flip1995 left a comment

Nice! r=me when Manishearth/compiletest-rs#151 is merged and the dependency is adapted

@bors

This comment has been hidden.

@phansch phansch force-pushed the phansch:brave_newer_ui_tests branch from 3270724 to 298aedf Dec 28, 2018
Cargo.toml Outdated Show resolved Hide resolved
@phansch
Copy link
Member Author

@phansch phansch commented Jan 3, 2019

@bors r=flip1995 🚀

I will write up a tracking issue for adding rustfix coverage later today.

@bors
Copy link
Contributor

@bors bors commented Jan 3, 2019

📌 Commit ec1395a has been approved by flip1995

@bors
Copy link
Contributor

@bors bors commented Jan 3, 2019

Testing commit ec1395a with merge 5b8b01e...

bors added a commit that referenced this pull request Jan 3, 2019
Integrate rustfix into Clippy test suite

Once the [PR to compiletest-rs](Manishearth/compiletest-rs#151) is reviewed and merged this fixes #2376.

I will create a separate tracking issue for adding `run-rustfix` to all tests.
@bors
Copy link
Contributor

@bors bors commented Jan 3, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: flip1995
Pushing 5b8b01e to master...

@bors bors merged commit ec1395a into rust-lang:master Jan 3, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bors
homu Test successful
Details
@phansch phansch deleted the phansch:brave_newer_ui_tests branch Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants