Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate rustfix into Clippy test suite #3519

Merged
merged 6 commits into from
Jan 3, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Dec 9, 2018

Once the PR to compiletest-rs is reviewed and merged this fixes #2376.

I will create a separate tracking issue for adding run-rustfix to all tests.

@phansch
Copy link
Member Author

phansch commented Dec 9, 2018

It looks like it already found an incorrect suggestion for the unnecessary_ref lint 😄

@phansch
Copy link
Member Author

phansch commented Dec 9, 2018

@bors hello?

@bors
Copy link
Collaborator

bors commented Dec 9, 2018

😪 I'm awake I'm awake

@phansch phansch added the S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work label Dec 10, 2018
@phansch phansch changed the title WIP: Integrate rustfix into Clippy test suite Integrate rustfix into Clippy test suite Dec 10, 2018
@bors

This comment has been minimized.

Copy link
Member

@flip1995 flip1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! r=me when Manishearth/compiletest-rs#151 is merged and the dependency is adapted

@bors

This comment has been minimized.

@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work labels Jan 3, 2019
Cargo.toml Outdated Show resolved Hide resolved
@phansch
Copy link
Member Author

phansch commented Jan 3, 2019

@bors r=flip1995 🚀

I will write up a tracking issue for adding rustfix coverage later today.

@bors
Copy link
Collaborator

bors commented Jan 3, 2019

📌 Commit ec1395a has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Jan 3, 2019

⌛ Testing commit ec1395a with merge 5b8b01e...

bors added a commit that referenced this pull request Jan 3, 2019
Integrate rustfix into Clippy test suite

Once the [PR to compiletest-rs](Manishearth/compiletest-rs#151) is reviewed and merged this fixes #2376.

I will create a separate tracking issue for adding `run-rustfix` to all tests.
@phansch phansch removed the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Jan 3, 2019
@bors
Copy link
Collaborator

bors commented Jan 3, 2019

☀️ Test successful - status-appveyor, status-travis
Approved by: flip1995
Pushing 5b8b01e to master...

@bors bors merged commit ec1395a into rust-lang:master Jan 3, 2019
@phansch phansch deleted the brave_newer_ui_tests branch January 3, 2019 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate rustfix into clippy test suite
3 participants