Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: tool lints are stable now #3527

Merged
merged 3 commits into from Dec 11, 2018
Merged

Conversation

phansch
Copy link
Member

@phansch phansch commented Dec 10, 2018

No description provided.

@matthiaskrgr
Copy link
Member

Nit: perhaps throw in a quick note that this also works with lint groups? (like clippy::pedantic)
LGTM besides that. :)

README.md Outdated
```

If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to clippy during the run: `cargo clippy -- -A lint_name` will run clippy with `lint_name` disabled and `cargo clippy -- -W lint_name` will run it with that enabled. On newer compilers you may need to use `clippy::lint_name` instead.
If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to clippy during the run: `cargo clippy -- -A clippy::lint_name` will run clippy with `lint_name` disabled and `cargo clippy -- -W clippy::lint_name` will run it with that enabled. This also works with lint groups. For example you can run Clippy with warnings for all lints enabled: `cargo clippy -- -W clippy::pedantic`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, there was some convention to always use Clippy (capitalized) instead of clippy established some time ago I think?
r=me with that changed (sorry should have remembered earlier =/ )

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right =) I also changed it in some more places in 0c93e4c just now

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I see it still mentions nightly there.. I will fix that too while I'm at it.

README.md Outdated
rust:
- nightly
before_script:
- rustup component add clippy --toolchain=nightly || cargo install --git https://github.com/rust-lang/rust-clippy/ --force clippy
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I think this is still useful for people who want to run clippy on the nightly channel instead of beta or stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in, this hack was useful before it was broken (#3523) for people who didn't want to wait for new rust releases to get clippy updates.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed that commit again, should be fine now 👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phansch Is #3523 still meant to fail? Because it does.

@phansch
Copy link
Member Author

phansch commented Dec 11, 2018

@bors r=matthiaskrgr

@bors
Copy link
Collaborator

bors commented Dec 11, 2018

📌 Commit 0c93e4c has been approved by matthiaskrgr

@bors
Copy link
Collaborator

bors commented Dec 11, 2018

⌛ Testing commit 0c93e4c with merge d6db677...

bors added a commit that referenced this pull request Dec 11, 2018
readme: tool lints are stable now

None
@bors
Copy link
Collaborator

bors commented Dec 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matthiaskrgr
Pushing d6db677 to master...

@bors bors merged commit 0c93e4c into rust-lang:master Dec 11, 2018
@phansch phansch deleted the update_readme2 branch December 11, 2018 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants