New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme: tool lints are stable now #3527

Merged
merged 3 commits into from Dec 11, 2018

Conversation

Projects
None yet
4 participants
@phansch
Copy link
Collaborator

phansch commented Dec 10, 2018

No description provided.

@matthiaskrgr

This comment has been minimized.

Copy link
Collaborator

matthiaskrgr commented Dec 10, 2018

Nit: perhaps throw in a quick note that this also works with lint groups? (like clippy::pedantic)
LGTM besides that. :)

README.md Outdated
```

If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to clippy during the run: `cargo clippy -- -A lint_name` will run clippy with `lint_name` disabled and `cargo clippy -- -W lint_name` will run it with that enabled. On newer compilers you may need to use `clippy::lint_name` instead.
If you do not want to include your lint levels in your code, you can globally enable/disable lints by passing extra flags to clippy during the run: `cargo clippy -- -A clippy::lint_name` will run clippy with `lint_name` disabled and `cargo clippy -- -W clippy::lint_name` will run it with that enabled. This also works with lint groups. For example you can run Clippy with warnings for all lints enabled: `cargo clippy -- -W clippy::pedantic`

This comment has been minimized.

@matthiaskrgr

matthiaskrgr Dec 10, 2018

Collaborator

Ah, there was some convention to always use Clippy (capitalized) instead of clippy established some time ago I think?
r=me with that changed (sorry should have remembered earlier =/ )

This comment has been minimized.

@phansch

phansch Dec 10, 2018

Collaborator

You're right =) I also changed it in some more places in 0c93e4c just now

This comment has been minimized.

@phansch

phansch Dec 10, 2018

Collaborator

Now I see it still mentions nightly there.. I will fix that too while I'm at it.

README.md Outdated
rust:
- nightly
before_script:
- rustup component add clippy --toolchain=nightly || cargo install --git https://github.com/rust-lang/rust-clippy/ --force clippy

This comment has been minimized.

@matthiaskrgr

matthiaskrgr Dec 10, 2018

Collaborator

Hmm, I think this is still useful for people who want to run clippy on the nightly channel instead of beta or stable.

This comment has been minimized.

@matthiaskrgr

matthiaskrgr Dec 10, 2018

Collaborator

As in, this hack was useful before it was broken (#3523) for people who didn't want to wait for new rust releases to get clippy updates.

This comment has been minimized.

@phansch

phansch Dec 11, 2018

Collaborator

removed that commit again, should be fine now 👍

This comment has been minimized.

@aldanor

aldanor Dec 11, 2018

@phansch Is #3523 still meant to fail? Because it does.

@phansch phansch force-pushed the phansch:update_readme2 branch from c31543c to 0c93e4c Dec 11, 2018

@phansch phansch closed this Dec 11, 2018

@phansch phansch reopened this Dec 11, 2018

@phansch

This comment has been minimized.

Copy link
Collaborator

phansch commented Dec 11, 2018

@bors r=matthiaskrgr

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 11, 2018

📌 Commit 0c93e4c has been approved by matthiaskrgr

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 11, 2018

⌛️ Testing commit 0c93e4c with merge d6db677...

bors added a commit that referenced this pull request Dec 11, 2018

Auto merge of #3527 - phansch:update_readme2, r=matthiaskrgr
readme: tool lints are stable now

None
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 11, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: matthiaskrgr
Pushing d6db677 to master...

@bors bors merged commit 0c93e4c into rust-lang:master Dec 11, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:update_readme2 branch Dec 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment