Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make integration tests fail on 'E0463' #3552

Merged
merged 1 commit into from Dec 19, 2018

Conversation

@phansch
Copy link
Member

@phansch phansch commented Dec 14, 2018

cc #3523

@matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 14, 2018

Thanks!
r=me once this no longer breaks ci :p

n.b.: maybe it should grep for E0463 instead in case the error message wording changes?

@phansch
Copy link
Member Author

@phansch phansch commented Dec 14, 2018

Good point, I will change it :)

@phansch phansch force-pushed the phansch:make_integration_tests_fail_again branch from 01ab70e to d7ba64e Dec 14, 2018
@phansch phansch changed the title Make integration tests fail on 'cant find crate' Make integration tests fail on 'E0463' Dec 14, 2018
@phansch phansch force-pushed the phansch:make_integration_tests_fail_again branch from d7ba64e to abab181 Dec 14, 2018
@oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented Dec 19, 2018

@bors r+ this will probably pass after #3546 is through

@bors
Copy link
Contributor

@bors bors commented Dec 19, 2018

📌 Commit abab181 has been approved by oli-obk

bors added a commit that referenced this pull request Dec 19, 2018
…i-obk

Make integration tests fail on 'E0463'

cc #3523
@bors
Copy link
Contributor

@bors bors commented Dec 19, 2018

Testing commit abab181 with merge ff203b3...

@phansch
Copy link
Member Author

@phansch phansch commented Dec 19, 2018

@bors are you still there?

@bors
Copy link
Contributor

@bors bors commented Dec 19, 2018

🍰 Target acquired

@phansch
Copy link
Member Author

@phansch phansch commented Dec 19, 2018

@bors retry

@bors
Copy link
Contributor

@bors bors commented Dec 19, 2018

Testing commit abab181 with merge 691e5e7...

bors added a commit that referenced this pull request Dec 19, 2018
…i-obk

Make integration tests fail on 'E0463'

cc #3523
@bors
Copy link
Contributor

@bors bors commented Dec 19, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: oli-obk
Pushing 691e5e7 to master...

@bors bors merged commit abab181 into rust-lang:master Dec 19, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bors
homu Test successful
Details
@phansch phansch deleted the phansch:make_integration_tests_fail_again branch Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants