New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change contrib.md hierarchy, link to it from readme #3569

Merged
merged 2 commits into from Dec 22, 2018

Conversation

Projects
None yet
3 participants
@phansch
Copy link
Collaborator

phansch commented Dec 21, 2018

'How Clippy works' and 'How to fix nightly failures' are not exactly part
of 'Writing code'.

Change contrib.md hierarchy, link to it from readme
'How Clippy works' and 'How to fix nightly failures' are not exactly part
of 'Writing code'.
@phansch

This comment has been minimized.

Copy link
Collaborator

phansch commented Dec 21, 2018

Looks like a spurious network failure on AppVeyor:

 https://s3-us-west-1.amazonaws.com/rust-lang-ci2/rustc-builds/6d34ec18c7d7e574553f6347ecf08e1e1c45c13d/rust-src-nightly.tar.xz: an error occurred trying to connect: 
A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. (os error 10060)

@phansch phansch closed this Dec 21, 2018

@phansch phansch reopened this Dec 21, 2018

Show resolved Hide resolved README.md Outdated
@phansch

This comment has been minimized.

Copy link
Collaborator

phansch commented Dec 22, 2018

@bors r=flip1995

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2018

📌 Commit cef8f57 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2018

⌛️ Testing commit cef8f57 with merge d3c747c...

bors added a commit that referenced this pull request Dec 22, 2018

Auto merge of #3569 - phansch:update_contributing, r=flip1995
Change contrib.md hierarchy, link to it from readme

'How Clippy works' and 'How to fix nightly failures' are not exactly part
of 'Writing code'.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Dec 22, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: flip1995
Pushing d3c747c to master...

@bors bors merged commit cef8f57 into rust-lang:master Dec 22, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:update_contributing branch Dec 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment