Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE in needless_pass_by_value lint #3744

Merged
merged 1 commit into from Feb 10, 2019
Merged

Fix ICE in needless_pass_by_value lint #3744

merged 1 commit into from Feb 10, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Feb 6, 2019

If I understand it correctly, we were first creating a type with a
RegionKind::ReErased region and then deleted it again in
util::implements_trait with:

cx.tcx.erase_regions(&ty);

causing the type query to fail.

It looks like using ReEmpty works around that deletion.

Fixes #3144

@phansch phansch force-pushed the phansch:fix3144 branch from f15549b to 3a7fffc Feb 6, 2019
If I understand it correctly, we were first creating a type with a
`RegionKind::ReErased` region and then deleted it again in
`util::implements_trait` with:

    cx.tcx.erase_regions(&ty);

causing the type query to fail.

It looks like using `ReEmpty` works around that deletion.
@phansch phansch force-pushed the phansch:fix3144 branch from 3a7fffc to f3cd819 Feb 6, 2019
@oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented Feb 10, 2019

@bors r+

@bors
Copy link
Contributor

@bors bors commented Feb 10, 2019

📌 Commit f3cd819 has been approved by oli-obk

@bors
Copy link
Contributor

@bors bors commented Feb 10, 2019

Testing commit f3cd819 with merge 2755d12...

bors added a commit that referenced this pull request Feb 10, 2019
Fix ICE in needless_pass_by_value lint

If I understand it correctly, we were first creating a type with a
`RegionKind::ReErased` region and then deleted it again in
`util::implements_trait` with:

    cx.tcx.erase_regions(&ty);

causing the type query to fail.

It looks like using `ReEmpty` works around that deletion.

Fixes #3144
@bors
Copy link
Contributor

@bors bors commented Feb 10, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 2755d12 to master...

@bors bors merged commit f3cd819 into rust-lang:master Feb 10, 2019
3 checks passed
3 checks passed
@travis-ci
Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bors
homu Test successful
Details
@phansch phansch deleted the phansch:fix3144 branch Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants