Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ICE #3747 #3805

Merged
merged 1 commit into from Feb 25, 2019

Conversation

Projects
None yet
4 participants
@martinsp
Copy link
Contributor

commented Feb 23, 2019

I'm not sure if this was the correct approach.

I don't know if I put tests/ui/crashses/ice-3747.rs in correct place because the test always passed when I ran it with cargo test, even without the fix applied.

If I run that test with env CLIPPY_TESTS=true cargo run --bin clippy-driver -- -L ./target/debug tests/ui/crashes/ice-3747.rs then the test correctly fails without the fix applied

fixes #3747

@mati865

This comment has been minimized.

Copy link
Contributor

commented Feb 23, 2019

I don't know why you put my name into the commit. You fixed it and John Firebaugh created minimal example.

Fix ICE #3747
[Martins Polakovs, John Firebaugh]
@martinsp

This comment has been minimized.

Copy link
Contributor Author

commented Feb 23, 2019

I don't know why you put my name into the commit. You fixed it and John Firebaugh created minimal example.

you are right, I wanted to put John Firebaugh in commit, somehow copied the wrong name. Fixed the commit message.

@Manishearth

This comment has been minimized.

Copy link
Member

commented Feb 25, 2019

@bors r+

thanks!

@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

📌 Commit 391ee79 has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

⌛️ Testing commit 391ee79 with merge cd29740...

bors added a commit that referenced this pull request Feb 25, 2019

Auto merge of #3805 - martinsp:ice-3747, r=Manishearth
Fix ICE #3747

I'm not sure if this was the correct approach.

I don't know if I put tests/ui/crashses/ice-3747.rs in correct place because the test always passed when I ran it with `cargo test`, even without the fix applied.

If I run that test with `env CLIPPY_TESTS=true cargo run --bin clippy-driver -- -L ./target/debug tests/ui/crashes/ice-3747.rs` then the test correctly fails without the fix applied

fixes #3747
@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 25, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing cd29740 to master...

@bors bors merged commit 391ee79 into rust-lang:master Feb 25, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

bors added a commit to rust-lang/rust that referenced this pull request Apr 23, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 9, 2019

he
Update rust to version 1.34.1.
Pkgsrc changes: basically none.  Build verified on NetBSD 8.0/i386.

Upstream changes:

Version 1.34.1 (2019-04-25)
===========================

* [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821]
* [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844]
* [Fix Clippy panic when checking some macros][clippy/3805]

[clippy/3821]: rust-lang/rust-clippy#3821
[clippy/3844]: rust-lang/rust-clippy#3844
[clippy/3805]: rust-lang/rust-clippy#3805

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 19, 2019

he
Update rust to version 1.34.1.
Pkgsrc changes: basically none.  Build verified on NetBSD 8.0/i386.

Upstream changes:

Version 1.34.1 (2019-04-25)
===========================

* [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821]
* [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844]
* [Fix Clippy panic when checking some macros][clippy/3805]

[clippy/3821]: rust-lang/rust-clippy#3821
[clippy/3844]: rust-lang/rust-clippy#3844
[clippy/3805]: rust-lang/rust-clippy#3805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.