Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract diagnostics module and document some functions #3810

Merged
merged 2 commits into from Feb 24, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Feb 24, 2019

This moves the lint building functions from utils/mod.rs to their own
utils/diagnostics.rs file. Also adds documentation for three of them.

phansch added 2 commits Feb 24, 2019
This moves the lint building functions from `utils/mod.rs` to their own
`utils/diagnostics.rs` file. Also adds documentation for three of them.
@flip1995
Copy link
Member

@flip1995 flip1995 commented Feb 24, 2019

needs a rebase once #3790 is merged. r=me after rebase.

@flip1995
Copy link
Member

@flip1995 flip1995 commented Feb 24, 2019

Oh wait this should go through without a rebase, oops. Let's queue this.

@bors r+

@bors
Copy link
Contributor

@bors bors commented Feb 24, 2019

📌 Commit 7d883cd has been approved by flip1995

bors added a commit that referenced this issue Feb 24, 2019
Extract diagnostics module and document some functions

This moves the lint building functions from `utils/mod.rs` to their own
`utils/diagnostics.rs` file. Also adds documentation for three of them.
@bors
Copy link
Contributor

@bors bors commented Feb 24, 2019

Testing commit 7d883cd with merge 5833e4d...

@bors
Copy link
Contributor

@bors bors commented Feb 24, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 5833e4d to master...

@bors bors merged commit 7d883cd into rust-lang:master Feb 24, 2019
1 of 3 checks passed
1 of 3 checks passed
@travis-ci[bot]
Travis CI - Pull Request Build Failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@bors
homu Test successful
Details
@phansch phansch deleted the refactor/extract_module branch Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants