Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not trigger redundant_closure when there is a difference in borrow… #3821

Merged

Conversation

Projects
None yet
3 participants
@g-bartoszek
Copy link
Contributor

commented Feb 26, 2019

… level between closure parameter and "self", fixes #3802

do not trigger redundant_closure when there is a difference in borrow…
… level between closure parameter and "self"
@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented Feb 26, 2019

@bors r+

Thanks!

@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

📌 Commit a7f4d41 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

⌛️ Testing commit a7f4d41 with merge 6e8931c...

bors added a commit that referenced this pull request Feb 26, 2019

Auto merge of #3821 - g-bartoszek:redundant_closure-different-borrow-…
…levels, r=oli-obk

do not trigger redundant_closure when there is a difference in borrow…

… level between closure parameter and "self", fixes  #3802
@bors

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: oli-obk
Pushing 6e8931c to master...

@bors bors merged commit a7f4d41 into rust-lang:master Feb 26, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

bors added a commit to rust-lang/rust that referenced this pull request Apr 23, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

bors added a commit to rust-lang/rust that referenced this pull request Apr 24, 2019

Auto merge of #60198 - pietroalbini:stable-next, r=Mark-Simulacrum
[stable] 1.34.1 point release

The release date is April 25th.

Included in this point release:

* #59891: Fix the link to sort_by_cached_key
* #59989: Fix links to Atomic* in RELEASES.md
* rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747
* rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow...
* rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 9, 2019

he
Update rust to version 1.34.1.
Pkgsrc changes: basically none.  Build verified on NetBSD 8.0/i386.

Upstream changes:

Version 1.34.1 (2019-04-25)
===========================

* [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821]
* [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844]
* [Fix Clippy panic when checking some macros][clippy/3805]

[clippy/3821]: rust-lang/rust-clippy#3821
[clippy/3844]: rust-lang/rust-clippy#3844
[clippy/3805]: rust-lang/rust-clippy#3805

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request May 19, 2019

he
Update rust to version 1.34.1.
Pkgsrc changes: basically none.  Build verified on NetBSD 8.0/i386.

Upstream changes:

Version 1.34.1 (2019-04-25)
===========================

* [Fix false positives for the `redundant_closure` Clippy lint][clippy/3821]
* [Fix false positives for the `missing_const_for_fn` Clippy lint][clippy/3844]
* [Fix Clippy panic when checking some macros][clippy/3805]

[clippy/3821]: rust-lang/rust-clippy#3821
[clippy/3844]: rust-lang/rust-clippy#3844
[clippy/3805]: rust-lang/rust-clippy#3805
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.