Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Extract `trait_ref_of_method` function #3851

Merged
merged 4 commits into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@phansch
Copy link
Collaborator

commented Mar 7, 2019

This pattern was used in three places after #3844, so I think it's worth moving it into utils/mod.rs and documenting it.

@phansch phansch force-pushed the phansch:refactor_trait_stuff branch from 60e6b70 to a6b082c Mar 7, 2019

@phansch phansch force-pushed the phansch:refactor_trait_stuff branch from a6b082c to e1d47cd Mar 7, 2019

Show resolved Hide resolved clippy_lints/src/utils/mod.rs Outdated

flip1995 and others added some commits Mar 8, 2019

Update clippy_lints/src/utils/mod.rs
Co-Authored-By: phansch <dev@phansch.net>
fmt

@phansch phansch force-pushed the phansch:refactor_trait_stuff branch from f84b34a to 131b89b Mar 8, 2019

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@bors r+ rollup

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

📌 Commit 131b89b has been approved by flip1995

flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Mar 9, 2019

Rollup merge of rust-lang#3851 - phansch:refactor_trait_stuff, r=flip…
…1995

Refactor: Extract `trait_ref_of_method` function

This pattern was used in three places after rust-lang#3844, so I think it's worth moving it into `utils/mod.rs` and documenting it.

@flip1995 flip1995 referenced this pull request Mar 9, 2019

Merged

Rollup of 3 pull requests #3861

bors added a commit that referenced this pull request Mar 9, 2019

Auto merge of #3861 - flip1995:rollup, r=flip1995
Rollup of 3 pull requests

Successful merges:

 - #3851 (Refactor: Extract `trait_ref_of_method` function)
 - #3852 (Refactor: Cleanup one part of assign_ops lint)
 - #3857 (Document match_path, improve match_qpath docs)

Failed merges:

r? @ghost

@bors bors merged commit 131b89b into rust-lang:master Mar 9, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.