Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Remove utils::opt_def_id #3860

Merged
merged 1 commit into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@phansch
Copy link
Collaborator

commented Mar 8, 2019

This removes some indirection. Probably this method was uplifted to
rustc at some point?

Refactor: Remove utils::opt_def_id
This removes some indirection. Probably this method was uplifted to
rustc at some point?
@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

📌 Commit 9d97ed6 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

⌛️ Testing commit 9d97ed6 with merge 7358df0...

bors added a commit that referenced this pull request Mar 9, 2019

Auto merge of #3860 - phansch:refactor_out_opt_def_id, r=flip1995
Refactor: Remove utils::opt_def_id

This removes some indirection. Probably this method was uplifted to
rustc at some point?
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

💔 Test failed - checks-travis

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2019

@bors retry

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

⌛️ Testing commit 9d97ed6 with merge ccfbfb8...

bors added a commit that referenced this pull request Mar 9, 2019

Auto merge of #3860 - phansch:refactor_out_opt_def_id, r=flip1995
Refactor: Remove utils::opt_def_id

This removes some indirection. Probably this method was uplifted to
rustc at some point?
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 9, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing ccfbfb8 to master...

@bors bors merged commit 9d97ed6 into rust-lang:master Mar 9, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.