Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more HirId-ification #3873

Merged
merged 3 commits into from Mar 13, 2019

Conversation

Projects
None yet
3 participants
@phansch
Copy link
Collaborator

commented Mar 12, 2019

  • 8a59f81: Rename span_lint_node* functions to span_lint_hir*
  • a457258: Use HirId instead of NodeId for lookup
Rename span_lint_node* functions to span_lint_hir*
Because they now take a `hir_id` instead of a `node_id` argument.

@phansch phansch force-pushed the phansch:hiridification branch from 45b018f to a457258 Mar 12, 2019

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Mar 13, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

📌 Commit bf86c1b has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

⌛️ Testing commit bf86c1b with merge 99fdf26...

bors added a commit that referenced this pull request Mar 13, 2019

Auto merge of #3873 - phansch:hiridification, r=flip1995
Some more HirId-ification

* 8a59f81: Rename span_lint_node* functions to span_lint_hir*
* a457258: Use `HirId` instead of `NodeId` for lookup
@bors

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 99fdf26 to master...

@bors bors merged commit bf86c1b into rust-lang:master Mar 13, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@phansch phansch deleted the phansch:hiridification branch Mar 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.