Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more HirId-ification #3873

Merged
merged 3 commits into from Mar 13, 2019
Merged

Some more HirId-ification #3873

merged 3 commits into from Mar 13, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Mar 12, 2019

  • 8a59f81: Rename span_lint_node* functions to span_lint_hir*
  • a457258: Use HirId instead of NodeId for lookup

Because they now take a `hir_id` instead of a `node_id` argument.
@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Mar 12, 2019
@phansch phansch added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Mar 12, 2019
@phansch phansch added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Mar 13, 2019
@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 13, 2019

📌 Commit bf86c1b has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 13, 2019

⌛ Testing commit bf86c1b with merge 99fdf26...

bors added a commit that referenced this pull request Mar 13, 2019
Some more HirId-ification

* 8a59f81: Rename span_lint_node* functions to span_lint_hir*
* a457258: Use `HirId` instead of `NodeId` for lookup
@bors
Copy link
Collaborator

bors commented Mar 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 99fdf26 to master...

@bors bors merged commit bf86c1b into rust-lang:master Mar 13, 2019
@phansch phansch deleted the hiridification branch March 13, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants