Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustfix tests for mistyped_literal_suffix lint #3888

Conversation

phansch
Copy link
Member

@phansch phansch commented Mar 15, 2019

This moves all mistyped_literal_suffix tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887

@flip1995
Copy link
Member

Rustfmt on tests/ui/mistyped_literal_suffix.rs required. After that r=me (Just merge this directly instead of #3887 first)

@flip1995 flip1995 added the S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) label Mar 15, 2019
@phansch
Copy link
Member Author

phansch commented Mar 15, 2019

0ba45a9 should make the build pass once Clippy builds again. I'm not available until Monday so feel free to r+ once it works =)

@flip1995
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

📌 Commit 0ba45a9 has been approved by flip1995

@flip1995
Copy link
Member

Oh wait #3893 isn't merged yet

@bors r-

@phansch
Copy link
Member Author

phansch commented Mar 18, 2019

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

📌 Commit 0ba45a9 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 18, 2019

⌛ Testing commit 0ba45a9 with merge 65ed3dd...

bors added a commit that referenced this pull request Mar 18, 2019
…nd_rustfix, r=flip1995

Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
@bors
Copy link
Collaborator

bors commented Mar 18, 2019

💔 Test failed - checks-travis

The moved tests were part of `tests/ui/literals.rs` before. Now they are
placed in `tests/ui/unreadable_literal.rs`, which now also runs
`rustfix` on these 4 extra let statements.
This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc rust-lang#3603, rust-lang#2038

Based on rust-lang#3887
@phansch phansch force-pushed the extract_mistyped_literal_suffix_tests_and_rustfix branch from 0ba45a9 to 0452704 Compare March 19, 2019 05:57
@phansch
Copy link
Member Author

phansch commented Mar 19, 2019

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented Mar 19, 2019

📌 Commit 0452704 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Mar 19, 2019

⌛ Testing commit 0452704 with merge c7d4445...

bors added a commit that referenced this pull request Mar 19, 2019
…nd_rustfix, r=flip1995

Add rustfix tests for mistyped_literal_suffix lint

This moves all `mistyped_literal_suffix` tests to their own file and
enables rustfix tests for them.

cc #3603, #2038

Based on #3887
@bors
Copy link
Collaborator

bors commented Mar 19, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing c7d4445 to master...

@bors bors merged commit 0452704 into rust-lang:master Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants