Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing `// run-pass` annotations to ICE tests #3922

Merged
merged 1 commit into from Apr 6, 2019

Conversation

Projects
None yet
2 participants
@phansch
Copy link
Collaborator

commented Apr 5, 2019

compiletest UI tests do not fail when encountering panics and ICEs
unless the // run-pass flag is used.

(This was forgotten in #3743)

Add missing `// run-pass` annotations to ICE tests
compiletest UI tests do not fail when encountering panics and ICEs
unless the `// run-pass` flag is used.

(This was forgotten in #3743)
@phansch

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 5, 2019

I still want to make sure that using // run-pass will actually trigger Clippy lints and fail on potential panics inside their code. (I only tested it with a raw panic! in a crash test file)

edit: This seems to work correctly now 🎊

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2019

Would //compile-pass suffice?

@phansch

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 5, 2019

Going to give it a try later 👍

@phansch

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 6, 2019

Currently not, because // compile-pass is not implemented in compiletest-rs, only in Rust's compiletest. I opened laumann/compiletest-rs#168 for adding it to compiletest-rs

@oli-obk oli-obk merged commit b996fd5 into master Apr 6, 2019

2 of 4 checks passed

continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details

@oli-obk oli-obk deleted the run-pass branch Apr 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.