Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing // run-pass annotations to ICE tests #3922

Merged
merged 1 commit into from Apr 6, 2019
Merged

Add missing // run-pass annotations to ICE tests #3922

merged 1 commit into from Apr 6, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Apr 5, 2019

compiletest UI tests do not fail when encountering panics and ICEs
unless the // run-pass flag is used.

(This was forgotten in #3743)

compiletest UI tests do not fail when encountering panics and ICEs
unless the `// run-pass` flag is used.

(This was forgotten in #3743)
@phansch
Copy link
Member Author

@phansch phansch commented Apr 5, 2019

I still want to make sure that using // run-pass will actually trigger Clippy lints and fail on potential panics inside their code. (I only tested it with a raw panic! in a crash test file)

edit: This seems to work correctly now 🎊

@oli-obk
Copy link
Collaborator

@oli-obk oli-obk commented Apr 5, 2019

Would //compile-pass suffice?

@phansch
Copy link
Member Author

@phansch phansch commented Apr 5, 2019

Going to give it a try later 👍

@phansch
Copy link
Member Author

@phansch phansch commented Apr 6, 2019

Currently not, because // compile-pass is not implemented in compiletest-rs, only in Rust's compiletest. I opened Manishearth/compiletest-rs#168 for adding it to compiletest-rs

@oli-obk oli-obk merged commit b996fd5 into master Apr 6, 2019
2 of 4 checks passed
2 of 4 checks passed
continuous-integration/appveyor/branch AppVeyor build failed
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
@travis-ci[bot]
Travis CI - Branch Build Passed
Details
@travis-ci[bot]
Travis CI - Pull Request Build Passed
Details
@oli-obk oli-obk deleted the run-pass branch Apr 6, 2019
@ebroto ebroto mentioned this pull request Sep 25, 2020
bors added a commit that referenced this issue Sep 25, 2020
UI tests cleanup

`@matthiaskrgr` noticed some `run-pass` annotations in some crash tests that were added in #3922. At that moment they seemed to be necessary to make the tests fail in case of an ICE, but they do not seem to be needed anymore. To test this I forced an ICE in a file with and without annotations, with and without stderr files, and the ICE makes the test fail every time.

In addition, I've applied a suggestion from `@ehuss` and `@jyn514` to add `emit=metadata` to the rustc flags for the UI tests. In my machine this improved the run time from ~17 to ~12 seconds.

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants