Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for Rust 1.34.0 #3950

Merged
merged 2 commits into from Apr 13, 2019

Conversation

Projects
None yet
4 participants
@phansch
Copy link
Collaborator

commented Apr 13, 2019

@phansch phansch force-pushed the phansch:update_changelog branch from c8f27fa to 543858d Apr 13, 2019

* New lint: [`assertions_on_constants`] to detect for example `assert!(true)`
* New lint: [`dbg_macro`] to detect uses of the `dbg!` macro
* New lint: [`missing_const_for_fn`] that can suggest functions to be made `const`
* New lint: [`too_many_lines`] to detect functions with excessive LOC

This comment has been minimized.

Copy link
@matthiaskrgr

matthiaskrgr Apr 13, 2019

Collaborator

Perhaps the configuration option too-many-lines-threshold: u64 should be mentioned here as well.
What do you think?

This comment has been minimized.

Copy link
@phansch

phansch Apr 13, 2019

Author Collaborator

Yeah, makes sense to mention the configuration options for new lints 👍

@phansch

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 13, 2019

@bors r=Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

📌 Commit 745d6fb has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

⌛️ Testing commit 745d6fb with merge 5939b61...

bors added a commit that referenced this pull request Apr 13, 2019

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 5939b61 to master...

@bors bors merged commit 745d6fb into rust-lang:master Apr 13, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.