Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for Rust 1.34.0 #3950

Merged
merged 2 commits into from Apr 13, 2019
Merged

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 13, 2019

CHANGELOG.md Outdated
* New lint: [`assertions_on_constants`] to detect for example `assert!(true)`
* New lint: [`dbg_macro`] to detect uses of the `dbg!` macro
* New lint: [`missing_const_for_fn`] that can suggest functions to be made `const`
* New lint: [`too_many_lines`] to detect functions with excessive LOC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps the configuration option too-many-lines-threshold: u64 should be mentioned here as well.
What do you think?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense to mention the configuration options for new lints 👍

@phansch
Copy link
Member Author

phansch commented Apr 13, 2019

@bors r=Manishearth

@bors
Copy link
Collaborator

bors commented Apr 13, 2019

📌 Commit 745d6fb has been approved by Manishearth

@bors
Copy link
Collaborator

bors commented Apr 13, 2019

⌛ Testing commit 745d6fb with merge 5939b61...

@bors
Copy link
Collaborator

bors commented Apr 13, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 5939b61 to master...

@bors bors merged commit 745d6fb into rust-lang:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants