Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-rustfix for deref_addrof lint #3976

Merged
merged 1 commit into from Apr 17, 2019

Conversation

Projects
None yet
3 participants
@phansch
Copy link
Collaborator

commented Apr 16, 2019

  • renames tests/ui/reference.{rs,stderr} to
    `tests/ui/deref_addrof.{rs,stderr}
  • Moves small part of the testfile to a separate file as the lint
    triggered again on the fixed code (as intended)
  • Adds // run-rustfix to tests/ui/deref_addrof.rs

cc #3630

@phansch phansch force-pushed the phansch:deref_addrof_rustfix branch from 29108bb to 75c591d Apr 16, 2019

Add run-rustfix for deref_addrof lint
* renames `tests/ui/reference.{rs,stderr}` to
  `tests/ui/deref_addrof.{rs,stderr}
* Moves small part of the testfile to a separate file as the lint
  triggered again on the fixed code (as intended)
* Adds `// run-rustfix` to `tests/ui/deref_addrof.rs`

@phansch phansch force-pushed the phansch:deref_addrof_rustfix branch from 75c591d to d1e84c6 Apr 16, 2019

@phansch phansch referenced this pull request Apr 16, 2019

Open

Tracking Issue: Fixing broken lint suggestions #3630

30 of 39 tasks complete
@flip1995

This comment has been minimized.

Copy link
Collaborator

commented Apr 16, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

📌 Commit d1e84c6 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

⌛️ Testing commit d1e84c6 with merge 1936368...

bors added a commit that referenced this pull request Apr 17, 2019

Auto merge of #3976 - phansch:deref_addrof_rustfix, r=flip1995
Add run-rustfix for deref_addrof lint

* renames `tests/ui/reference.{rs,stderr}` to
  `tests/ui/deref_addrof.{rs,stderr}
* Moves small part of the testfile to a separate file as the lint
  triggered again on the fixed code (as intended)
* Adds `// run-rustfix` to `tests/ui/deref_addrof.rs`

cc #3630
@bors

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 1936368 to master...

@bors bors merged commit d1e84c6 into rust-lang:master Apr 17, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details

@phansch phansch deleted the phansch:deref_addrof_rustfix branch Apr 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.