Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in module_name_repetitions lint #4006

Merged
merged 1 commit into from Apr 20, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Apr 19, 2019

This lint was triggering on modules inside expanded attrs, like
for example #[cfg(test)] and possibly more.

It was not reporting a location in #3892 because span.lo() and span.hi() both were 0.

Fixes #3892

changelog: Fix false positive in module_name_repetitions lint

This lint was triggering on modules inside expanded attrs, like
for example `#[cfg(test)]` and possibly more.
@@ -1,3 +1,5 @@
// compile-flags: --test
Copy link
Member Author

@phansch phansch Apr 19, 2019

I couldn't find another attribute that caused this issue, that's why the --test is included here.

@flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 20, 2019

@bors r+

@bors
Copy link
Contributor

@bors bors commented Apr 20, 2019

📌 Commit 850c24e has been approved by flip1995

@bors
Copy link
Contributor

@bors bors commented Apr 20, 2019

Testing commit 850c24e with merge 7a6d5c0...

bors added a commit that referenced this issue Apr 20, 2019
Fix false positive in module_name_repetitions lint

This lint was triggering on modules inside expanded attrs, like
for example `#[cfg(test)]` and possibly more.

It was not reporting a location in #3892 because `span.lo()` and `span.hi()` both were 0.

Fixes #3892

changelog: Fix false positive in `module_name_repetitions` lint
@bors
Copy link
Contributor

@bors bors commented Apr 20, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 7a6d5c0 to master...

@bors bors merged commit 850c24e into rust-lang:master Apr 20, 2019
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants