Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #4101 to beta #4104

Merged
merged 3 commits into from May 17, 2019

Conversation

Projects
None yet
5 participants
@Manishearth
Copy link
Member

commented May 16, 2019

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk

@Manishearth Manishearth force-pushed the Manishearth:beta-backports branch 4 times, most recently from 65a3eb4 to 81cf55d May 16, 2019

@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

r? @oli-obk @phansch

(if r+, just merge directly. I'll deal with upstream backporting later)

@Manishearth Manishearth force-pushed the Manishearth:beta-backports branch from 81cf55d to 5928041 May 17, 2019

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

The test files are broken. This was fixed in 08d2a0d. Should we fix this here or just ignore it (it doesn't really matter for the backport)?

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 059019a has been approved by oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 059019a with merge cb1ea7e...

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - status-appveyor

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 426faff has been approved by oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 426faff with merge 6b32f65...

@flip1995 flip1995 force-pushed the Manishearth:beta-backports branch from 426faff to 19adb57 May 17, 2019

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

Squashed the commits, for less noice on the backport branch.

@bors r=oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 19adb57 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 19adb57 with merge fe4cbe1...

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - status-appveyor

Show resolved Hide resolved .travis.yml
Backport #4101
#4101

Splits up redundant_closure's method checking into a pedantic lint

@oli-obk oli-obk force-pushed the Manishearth:beta-backports branch from 19adb57 to 9170ca3 May 17, 2019

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 9170ca3 has been approved by oli-obk

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 9170ca3 with merge 1f55631...

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - status-appveyor

@oli-obk

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 64a9f56 has been approved by oli-obk

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=oli-obk
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 64a9f56 with merge 825ac3a...

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

💔 Test failed - checks-travis

@flip1995

This comment has been minimized.

Copy link
Collaborator

commented May 17, 2019

"All checks have passed" 🎉 Now it's bors' turn

@bors r+

@bors

This comment was marked as outdated.

Copy link
Contributor

commented May 17, 2019

📌 Commit 28bde06 has been approved by flip1995

@bors

This comment was marked as outdated.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 28bde06 with merge 8434618...

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=flip1995
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment was marked as outdated.

Copy link
Contributor

commented May 17, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

📌 Commit 28bde06 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

⌛️ Testing commit 28bde06 with merge 265318d...

bors added a commit that referenced this pull request May 17, 2019

Auto merge of #4104 - Manishearth:beta-backports, r=flip1995
Backport #4101 to beta

This lint has been causing lots of problems.

I'll check up on other potential beta backports when I build the new changelog

r? @oli-obk
@bors

This comment has been minimized.

Copy link
Contributor

commented May 17, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 265318d to beta1.35...

@bors bors merged commit 28bde06 into rust-lang:beta1.35 May 17, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
@Manishearth

This comment has been minimized.

Copy link
Member Author

commented May 17, 2019

Yeah it's fine it the tests are kinda broken.

I'll put up a beta backport PR today

@Manishearth Manishearth deleted the Manishearth:beta-backports branch May 17, 2019

@Manishearth Manishearth referenced this pull request May 17, 2019

Merged

[beta] Update clippy #60918

bors added a commit to rust-lang/rust that referenced this pull request May 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.