Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifetimes UI test cleanup #4120

Merged

Conversation

@phansch
Copy link
Member

commented May 20, 2019

  • Removes an unneeded #![warn(clippy::extra_unused_lifetimes)] from
    the needless_lifetimes test - the tests for those are in a different
    file.

  • Renames unused_lt.{rs,stderr} to extra_unused_lifetimes.{rs,stderr}

  • Renames lifetimes.{rs,stderr} to needless_lifetimes.{rs,stderr}

Lifetimes UI test cleanup
* Removes an unneeded `#![warn(clippy::extra_unused_lifetimes)]` from
  the `needless_lifetimes` test - the tests for those are in a different
  file.

* Renames `unused_lt.{rs,stderr}` to `extra_unused_lifetimes.{rs,stderr}`
* Renames `lifetimes.{rs,stderr}` to `needless_lifetimes.{rs,stderr}`
@Manishearth

This comment has been minimized.

Copy link
Member

commented May 20, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

📌 Commit 3f38299 has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

⌛️ Testing commit 3f38299 with merge f5d57b9...

bors added a commit that referenced this pull request May 20, 2019
Auto merge of #4120 - phansch:needless_lifetimes_async_test_cleanup, …
…r=Manishearth

Lifetimes UI test cleanup

* Removes an unneeded `#![warn(clippy::extra_unused_lifetimes)]` from
  the `needless_lifetimes` test - the tests for those are in a different
  file.

* Renames `unused_lt.{rs,stderr}` to `extra_unused_lifetimes.{rs,stderr}`
* Renames `lifetimes.{rs,stderr}` to `needless_lifetimes.{rs,stderr}`
@bors

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

💔 Test failed - checks-travis

@phansch

This comment has been minimized.

Copy link
Member Author

commented May 20, 2019

Looks like our cargo integration test fails due to #4121: https://travis-ci.com/rust-lang/rust-clippy/jobs/201583608#L1011

@phansch

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

@bors retry (cargo integration test disabled)

@bors

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

⌛️ Testing commit 3f38299 with merge 64c1d3b...

bors added a commit that referenced this pull request May 22, 2019
Auto merge of #4120 - phansch:needless_lifetimes_async_test_cleanup, …
…r=Manishearth

Lifetimes UI test cleanup

* Removes an unneeded `#![warn(clippy::extra_unused_lifetimes)]` from
  the `needless_lifetimes` test - the tests for those are in a different
  file.

* Renames `unused_lt.{rs,stderr}` to `extra_unused_lifetimes.{rs,stderr}`
* Renames `lifetimes.{rs,stderr}` to `needless_lifetimes.{rs,stderr}`
@bors

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 64c1d3b to master...

@bors bors merged commit 3f38299 into rust-lang:master May 22, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:needless_lifetimes_async_test_cleanup branch May 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.