Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lifetimes UI test cleanup #4120

Merged

Conversation

@phansch
Copy link
Member

@phansch phansch commented May 20, 2019

  • Removes an unneeded #![warn(clippy::extra_unused_lifetimes)] from
    the needless_lifetimes test - the tests for those are in a different
    file.

  • Renames unused_lt.{rs,stderr} to extra_unused_lifetimes.{rs,stderr}

  • Renames lifetimes.{rs,stderr} to needless_lifetimes.{rs,stderr}

* Removes an unneeded `#![warn(clippy::extra_unused_lifetimes)]` from
  the `needless_lifetimes` test - the tests for those are in a different
  file.

* Renames `unused_lt.{rs,stderr}` to `extra_unused_lifetimes.{rs,stderr}`
* Renames `lifetimes.{rs,stderr}` to `needless_lifetimes.{rs,stderr}`
@Manishearth
Copy link
Member

@Manishearth Manishearth commented May 20, 2019

@bors r+

Loading

@bors
Copy link
Contributor

@bors bors commented May 20, 2019

📌 Commit 3f38299 has been approved by Manishearth

Loading

@bors
Copy link
Contributor

@bors bors commented May 20, 2019

Testing commit 3f38299 with merge f5d57b9...

Loading

bors added a commit that referenced this issue May 20, 2019
…r=Manishearth

Lifetimes UI test cleanup

* Removes an unneeded `#![warn(clippy::extra_unused_lifetimes)]` from
  the `needless_lifetimes` test - the tests for those are in a different
  file.

* Renames `unused_lt.{rs,stderr}` to `extra_unused_lifetimes.{rs,stderr}`
* Renames `lifetimes.{rs,stderr}` to `needless_lifetimes.{rs,stderr}`
@bors
Copy link
Contributor

@bors bors commented May 20, 2019

💔 Test failed - checks-travis

Loading

@phansch
Copy link
Member Author

@phansch phansch commented May 20, 2019

Looks like our cargo integration test fails due to #4121: https://travis-ci.com/rust-lang/rust-clippy/jobs/201583608#L1011

Loading

@phansch
Copy link
Member Author

@phansch phansch commented May 22, 2019

@bors retry (cargo integration test disabled)

Loading

@bors
Copy link
Contributor

@bors bors commented May 22, 2019

Testing commit 3f38299 with merge 64c1d3b...

Loading

bors added a commit that referenced this issue May 22, 2019
…r=Manishearth

Lifetimes UI test cleanup

* Removes an unneeded `#![warn(clippy::extra_unused_lifetimes)]` from
  the `needless_lifetimes` test - the tests for those are in a different
  file.

* Renames `unused_lt.{rs,stderr}` to `extra_unused_lifetimes.{rs,stderr}`
* Renames `lifetimes.{rs,stderr}` to `needless_lifetimes.{rs,stderr}`
@bors
Copy link
Contributor

@bors bors commented May 22, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing 64c1d3b to master...

Loading

@bors bors merged commit 3f38299 into rust-lang:master May 22, 2019
2 checks passed
Loading
@phansch phansch deleted the needless_lifetimes_async_test_cleanup branch May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants