Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Test Cleanup: No wrong_self_convention in methods.rs #4316

Merged
merged 1 commit into from Aug 1, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 1, 2019

These cases are already covered in tests/ui/wrong_self_convention.rs.

cc #2038

changelog: none

These cases are already covered in `tests/ui/wrong_self_convention.rs`.

cc rust-lang#2038
@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 1, 2019

Windows build is currently really unstable. But let's try to merge this. At least it will be marked as approved in the bors queue.

@bors r+

@bors
Copy link
Contributor

@bors bors commented Aug 1, 2019

📌 Commit 533abfa has been approved by flip1995

@bors
Copy link
Contributor

@bors bors commented Aug 1, 2019

Testing commit 533abfa with merge 807b740...

bors added a commit that referenced this issue Aug 1, 2019
UI Test Cleanup: No wrong_self_convention in methods.rs

These cases are already covered in `tests/ui/wrong_self_convention.rs`.

cc #2038
@bors
Copy link
Contributor

@bors bors commented Aug 1, 2019

💔 Test failed - checks-travis

@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 1, 2019

@bors retry

@bors
Copy link
Contributor

@bors bors commented Aug 1, 2019

Testing commit 533abfa with merge 3087e91...

bors added a commit that referenced this issue Aug 1, 2019
UI Test Cleanup: No wrong_self_convention in methods.rs

These cases are already covered in `tests/ui/wrong_self_convention.rs`.

cc #2038

changelog: none
@bors
Copy link
Contributor

@bors bors commented Aug 1, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 3087e91 to master...

@bors bors merged commit 533abfa into rust-lang:master Aug 1, 2019
2 checks passed
@phansch phansch deleted the method_rs_cleanup2 branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants