UI Test Cleanup: No wrong_self_convention in methods.rs #4316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These cases are already covered in `tests/ui/wrong_self_convention.rs`. cc rust-lang#2038
flip1995
approved these changes
Aug 1, 2019
|
Windows build is currently really unstable. But let's try to merge this. At least it will be marked as approved in the bors queue. @bors r+ |
|
📌 Commit 533abfa has been approved by |
bors
added a commit
that referenced
this pull request
Aug 1, 2019
UI Test Cleanup: No wrong_self_convention in methods.rs These cases are already covered in `tests/ui/wrong_self_convention.rs`. cc #2038
|
💔 Test failed - checks-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
Aug 1, 2019
UI Test Cleanup: No wrong_self_convention in methods.rs These cases are already covered in `tests/ui/wrong_self_convention.rs`. cc #2038 changelog: none
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These cases are already covered in
tests/ui/wrong_self_convention.rs.cc #2038
changelog: none