Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests: Enable running doc tests for complexity lints #4325

Merged
merged 2 commits into from Aug 3, 2019

Conversation

@phansch
Copy link
Member

commented Aug 2, 2019

changelog: none

master: 113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out
this PR: 181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out

cc #4319

@phansch phansch changed the title Doctests: Fix all complexity lint docs Doctests: Enable running doc tests for complexity lints Aug 2, 2019

@flip1995
Copy link
Member

left a comment

Thanks! r=me after NIT fix.

clippy_lints/src/explicit_write.rs Show resolved Hide resolved
clippy_lints/src/needless_borrowed_ref.rs Outdated Show resolved Hide resolved

@phansch phansch force-pushed the phansch:doctests_complexity branch from dc43389 to abfa8a9 Aug 2, 2019

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

@bors r=flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

📌 Commit abfa8a9 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

⌛️ Testing commit abfa8a9 with merge 7185ad5...

bors added a commit that referenced this pull request Aug 2, 2019
Auto merge of #4325 - phansch:doctests_complexity, r=flip1995
Doctests: Enable running doc tests for complexity lints

changelog: none

master: `113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out`
this PR: `181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out`

cc #4319
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 2, 2019

💔 Test failed - status-appveyor

phansch added a commit to phansch/rust-clippy that referenced this pull request Aug 3, 2019
Doctests: Enable running doc tests for perf lints
This should be possible to merge independently of rust-lang#4325

cc rust-lang#4319
Also enable doc tests for internal lints
Because there were fixed in the parent commit.
@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

@bors r=flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

📌 Commit eb68dc9 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

⌛️ Testing commit eb68dc9 with merge 12d215e...

bors added a commit that referenced this pull request Aug 3, 2019
Auto merge of #4325 - phansch:doctests_complexity, r=flip1995
Doctests: Enable running doc tests for complexity lints

changelog: none

master: `113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out`
this PR: `181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out`

cc #4319
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

💔 Test failed - checks-travis

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 3, 2019

@bors retry (spurious)

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

⌛️ Testing commit eb68dc9 with merge 3dc9183...

bors added a commit that referenced this pull request Aug 3, 2019
Auto merge of #4325 - phansch:doctests_complexity, r=flip1995
Doctests: Enable running doc tests for complexity lints

changelog: none

master: `113 passed; 0 failed; 91 ignored; 0 measured; 0 filtered out`
this PR: `181 passed; 0 failed; 110 ignored; 0 measured; 0 filtered out`

cc #4319
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 3dc9183 to master...

@bors bors merged commit eb68dc9 into rust-lang:master Aug 3, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Failed
Details
homu Test successful
Details
bors added a commit that referenced this pull request Aug 3, 2019
Auto merge of #4327 - phansch:doctests_perf, r=flip1995
Doctests: Enable running doc tests for perf lints

changelog: none

This should be possible to merge independently of #4325

cc #4319

@phansch phansch deleted the phansch:doctests_complexity branch Aug 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.