Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustup to latest rustc master #4328

Merged
merged 2 commits into from Aug 3, 2019
Merged

Rustup to latest rustc master #4328

merged 2 commits into from Aug 3, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 3, 2019

Broken due to:

changelog: none

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@phansch
Copy link
Member Author

@phansch phansch commented Aug 3, 2019

@bors r+ doesn't seem very controversial, so I'm going to r+ myself

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

📌 Commit d61df4f has been approved by phansch

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

Testing commit d61df4f with merge 5f57b68...

bors added a commit that referenced this issue Aug 3, 2019
Rustup to latest rustc master

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

💔 Test failed - status-appveyor

@mikerite
Copy link
Contributor

@mikerite mikerite commented Aug 3, 2019

In appveyor.yml, Try replacing

    - rustup component add rustfmt --toolchain nightly || echo "rustfmt nightly is unavailable"

with

    - rustup component add rustfmt --toolchain nightly & exit 0

It looks like that is the correct way to ignore if a command fails.
https://help.appveyor.com/discussions/questions/752-how-to-ignore-exit-codes-of-a-cmd

The format test should be able to handle rustfmt being missing.

@phansch
Copy link
Member Author

@phansch phansch commented Aug 3, 2019

Thanks, let's see if that works!

@bors r+

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

📌 Commit ff59f4a has been approved by phansch

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

Testing commit ff59f4a with merge a492dfc...

bors added a commit that referenced this issue Aug 3, 2019
Rustup to latest rustc master

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@phansch
Copy link
Member Author

@phansch phansch commented Aug 3, 2019

@bors retry (forgot changelog)

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

Testing commit ff59f4a with merge 6b88a62...

bors added a commit that referenced this issue Aug 3, 2019
Rustup to latest rustc master

Broken due to:

changelog: none

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)
@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member Author

@phansch phansch commented Aug 3, 2019

@bors retry (spurious)

@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

Testing commit ff59f4a with merge a24c704...

bors added a commit that referenced this issue Aug 3, 2019
Rustup to latest rustc master

Broken due to:

* rust-lang/rust#63180 (`Existential` -> `OpaqueTy`)
* rust-lang/rust#63121 (New fields for `FormatSpec`)

changelog: none
@bors
Copy link
Contributor

@bors bors commented Aug 3, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: phansch
Pushing a24c704 to master...

@bors bors merged commit ff59f4a into rust-lang:master Aug 3, 2019
2 checks passed
@phansch phansch deleted the rustup branch Aug 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants