Fix needless_bool suggestion with if--else-if--else #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit da49c2e has been approved by |
bors
added a commit
that referenced
this pull request
Aug 5, 2019
Fix needless_bool suggestion with if--else-if--else changelog: Fix `needless_bool` suggestion with if--else-if--else Closes #4334
|
💔 Test failed - status-appveyor |
|
|
phansch
force-pushed
the
fix_needless_bool_suggestion
branch
from
da49c2e
to
cdfb72a
Compare
|
@bors r=flip1995 |
|
📌 Commit cdfb72a has been approved by |
bors
added a commit
that referenced
this pull request
Aug 5, 2019
Fix needless_bool suggestion with if--else-if--else changelog: Fix `needless_bool` suggestion with if--else-if--else Closes #4334
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: Fix
needless_boolsuggestion with if--else-if--elseCloses #4334