Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix needless_bool suggestion with if--else-if--else #4335

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@phansch
Copy link
Member

commented Aug 4, 2019

changelog: Fix needless_bool suggestion with if--else-if--else

Closes #4334

@flip1995
Copy link
Member

left a comment

Thanks! r=me, once #4336 is merged

@flip1995

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

📌 Commit da49c2e has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

⌛️ Testing commit da49c2e with merge 48ee7a2...

bors added a commit that referenced this pull request Aug 5, 2019
Auto merge of #4335 - phansch:fix_needless_bool_suggestion, r=flip1995
Fix needless_bool suggestion with if--else-if--else

changelog: Fix `needless_bool` suggestion with if--else-if--else

Closes #4334
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

💔 Test failed - status-appveyor

@flip1995

This comment has been minimized.

Copy link
Member

commented Aug 5, 2019

./util/dev fmt

phansch added 2 commits Aug 4, 2019
fmt

@phansch phansch force-pushed the phansch:fix_needless_bool_suggestion branch from da49c2e to cdfb72a Aug 5, 2019

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

@bors r=flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

📌 Commit cdfb72a has been approved by flip1995

bors added a commit that referenced this pull request Aug 5, 2019
Auto merge of #4335 - phansch:fix_needless_bool_suggestion, r=flip1995
Fix needless_bool suggestion with if--else-if--else

changelog: Fix `needless_bool` suggestion with if--else-if--else

Closes #4334
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

⌛️ Testing commit cdfb72a with merge ea26a95...

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing ea26a95 to master...

@bors bors merged commit cdfb72a into rust-lang:master Aug 5, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:fix_needless_bool_suggestion branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.