Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix needless_bool suggestion with if--else-if--else #4335

Merged
merged 2 commits into from Aug 5, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 4, 2019

changelog: Fix needless_bool suggestion with if--else-if--else

Closes #4334

Copy link
Member

@flip1995 flip1995 left a comment

Thanks! r=me, once #4336 is merged

Loading

@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 5, 2019

@bors r+

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 5, 2019

📌 Commit da49c2e has been approved by flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 5, 2019

Testing commit da49c2e with merge 48ee7a2...

Loading

bors added a commit that referenced this issue Aug 5, 2019
Fix needless_bool suggestion with if--else-if--else

changelog: Fix `needless_bool` suggestion with if--else-if--else

Closes #4334
@bors
Copy link
Contributor

@bors bors commented Aug 5, 2019

💔 Test failed - status-appveyor

Loading

@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 5, 2019

./util/dev fmt

Loading

@phansch phansch force-pushed the fix_needless_bool_suggestion branch from da49c2e to cdfb72a Aug 5, 2019
@phansch
Copy link
Member Author

@phansch phansch commented Aug 5, 2019

@bors r=flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 5, 2019

📌 Commit cdfb72a has been approved by flip1995

Loading

bors added a commit that referenced this issue Aug 5, 2019
Fix needless_bool suggestion with if--else-if--else

changelog: Fix `needless_bool` suggestion with if--else-if--else

Closes #4334
@bors
Copy link
Contributor

@bors bors commented Aug 5, 2019

Testing commit cdfb72a with merge ea26a95...

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 5, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing ea26a95 to master...

Loading

@bors bors merged commit cdfb72a into rust-lang:master Aug 5, 2019
2 checks passed
Loading
@phansch phansch deleted the fix_needless_bool_suggestion branch Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants