Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-rustfix for needless_bool lint #4339

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 5, 2019

This splits up the needless_bool tests into fixable.rs and
simple.rs. simple.rs contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.
@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 6, 2019

@bors r+

Thanks!

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 6, 2019

📌 Commit 39c8f84 has been approved by flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 6, 2019

Testing commit 39c8f84 with merge 66045ff...

Loading

bors added a commit that referenced this issue Aug 6, 2019
Add run-rustfix for needless_bool lint

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630
@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 6, 2019

Oh wait. rustup needs to be merged first. I'm canceling the travis job. r=me once rustup is merged.

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 6, 2019

💔 Test failed - checks-travis

Loading

@phansch
Copy link
Member Author

@phansch phansch commented Aug 7, 2019

@bors r=flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: #4346

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

📌 Commit 39c8f84 has been approved by flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

Testing commit 39c8f84 with merge 8002005...

Loading

bors added a commit that referenced this issue Aug 7, 2019
Add run-rustfix for needless_bool lint

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630
@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

💔 Test failed - checks-travis

Loading

@phansch
Copy link
Member Author

@phansch phansch commented Aug 7, 2019

@bors retry

Loading

bors added a commit that referenced this issue Aug 7, 2019
Add run-rustfix for needless_bool lint

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630
@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

Testing commit 39c8f84 with merge e76ef1d...

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing e76ef1d to master...

Loading

@bors bors merged commit 39c8f84 into rust-lang:master Aug 7, 2019
2 checks passed
Loading
@phansch phansch deleted the rustfix_needless_bool branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants