Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add run-rustfix for needless_bool lint #4339

Merged
merged 1 commit into from Aug 7, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Aug 5, 2019

This splits up the needless_bool tests into fixable.rs and
simple.rs. simple.rs contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.
@flip1995
Copy link
Member

flip1995 commented Aug 6, 2019

@bors r+

Thanks!

@bors
Copy link
Collaborator

bors commented Aug 6, 2019

📌 Commit 39c8f84 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 6, 2019

⌛ Testing commit 39c8f84 with merge 66045ff...

bors added a commit that referenced this pull request Aug 6, 2019
Add run-rustfix for needless_bool lint

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630
@flip1995
Copy link
Member

flip1995 commented Aug 6, 2019

Oh wait. rustup needs to be merged first. I'm canceling the travis job. r=me once rustup is merged.

@bors
Copy link
Collaborator

bors commented Aug 6, 2019

💔 Test failed - checks-travis

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 7, 2019
@phansch
Copy link
Member Author

phansch commented Aug 7, 2019

@bors r=flip1995

@bors
Copy link
Collaborator

bors commented Aug 7, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
  • There's another pull request that is currently being tested, blocking this pull request: Update Readme #4346

@bors
Copy link
Collaborator

bors commented Aug 7, 2019

📌 Commit 39c8f84 has been approved by flip1995

@bors
Copy link
Collaborator

bors commented Aug 7, 2019

⌛ Testing commit 39c8f84 with merge 8002005...

bors added a commit that referenced this pull request Aug 7, 2019
Add run-rustfix for needless_bool lint

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630
@bors
Copy link
Collaborator

bors commented Aug 7, 2019

💔 Test failed - checks-travis

@phansch
Copy link
Member Author

phansch commented Aug 7, 2019

@bors retry

bors added a commit that referenced this pull request Aug 7, 2019
Add run-rustfix for needless_bool lint

This splits up the needless_bool tests into `fixable.rs` and
`simple.rs`. `simple.rs` contains the code that triggers the lint
diagnostic without a suggestion.

changelog: none

cc #3630
@bors
Copy link
Collaborator

bors commented Aug 7, 2019

⌛ Testing commit 39c8f84 with merge e76ef1d...

@bors
Copy link
Collaborator

bors commented Aug 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing e76ef1d to master...

@bors bors merged commit 39c8f84 into rust-lang:master Aug 7, 2019
@phansch phansch deleted the rustfix_needless_bool branch August 7, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants