Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit enum_variant_names if remainder starts with a numeric #4345

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 6, 2019

changelog: Fix false positive in pub_enum_variant_names and enum_variant_names

As per the reference, identifiers must start with a letter. So we don't suggest a better
variant naming in case the remainder would start with a numeric.

Fixes #739

As [per the reference](https://doc.rust-lang.org/reference/identifiers.html),
identifiers must start with a letter. So we don't suggest a better
variant naming in these cases.

Fixes rust-lang#739
@flip1995
Copy link
Member

@flip1995 flip1995 commented Aug 7, 2019

@bors r+

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

📌 Commit 0a988c6 has been approved by flip1995

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

Testing commit 0a988c6 with merge 317cbd9...

Loading

bors added a commit that referenced this issue Aug 7, 2019
Don't emit enum_variant_names if remainder starts with a numeric

changelog: Fix false positive in `pub_enum_variant_names` and `enum_variant_names`

As [per the reference](https://doc.rust-lang.org/reference/identifiers.html), identifiers must start with a letter. So we don't suggest a better
variant naming in case the remainder would start with a numeric.

Fixes #739
@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

💔 Test failed - checks-travis

Loading

@phansch
Copy link
Member Author

@phansch phansch commented Aug 7, 2019

@bors retry
Various spurious errors.

Loading

bors added a commit that referenced this issue Aug 7, 2019
Don't emit enum_variant_names if remainder starts with a numeric

changelog: Fix false positive in `pub_enum_variant_names` and `enum_variant_names`

As [per the reference](https://doc.rust-lang.org/reference/identifiers.html), identifiers must start with a letter. So we don't suggest a better
variant naming in case the remainder would start with a numeric.

Fixes #739
@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

Testing commit 0a988c6 with merge 286d528...

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 286d528 to master...

Loading

@bors bors merged commit 0a988c6 into rust-lang:master Aug 7, 2019
1 of 2 checks passed
Loading
@phansch phansch deleted the enum_variants_fix branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants