Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't emit enum_variant_names if remainder starts with a numeric #4345

Merged
merged 1 commit into from Aug 7, 2019

Conversation

@phansch
Copy link
Member

commented Aug 6, 2019

changelog: Fix false positive in pub_enum_variant_names and enum_variant_names

As per the reference, identifiers must start with a letter. So we don't suggest a better
variant naming in case the remainder would start with a numeric.

Fixes #739

Don't emit enum_variant_names if remainder starts with a numeric
As [per the reference](https://doc.rust-lang.org/reference/identifiers.html),
identifiers must start with a letter. So we don't suggest a better
variant naming in these cases.

Fixes #739
@flip1995

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

📌 Commit 0a988c6 has been approved by flip1995

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

⌛️ Testing commit 0a988c6 with merge 317cbd9...

bors added a commit that referenced this pull request Aug 7, 2019
Auto merge of #4345 - phansch:enum_variants_fix, r=flip1995
Don't emit enum_variant_names if remainder starts with a numeric

changelog: Fix false positive in `pub_enum_variant_names` and `enum_variant_names`

As [per the reference](https://doc.rust-lang.org/reference/identifiers.html), identifiers must start with a letter. So we don't suggest a better
variant naming in case the remainder would start with a numeric.

Fixes #739
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

💔 Test failed - checks-travis

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 7, 2019

@bors retry
Various spurious errors.

bors added a commit that referenced this pull request Aug 7, 2019
Auto merge of #4345 - phansch:enum_variants_fix, r=flip1995
Don't emit enum_variant_names if remainder starts with a numeric

changelog: Fix false positive in `pub_enum_variant_names` and `enum_variant_names`

As [per the reference](https://doc.rust-lang.org/reference/identifiers.html), identifiers must start with a letter. So we don't suggest a better
variant naming in case the remainder would start with a numeric.

Fixes #739
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

⌛️ Testing commit 0a988c6 with merge 286d528...

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 286d528 to master...

@bors bors merged commit 0a988c6 into rust-lang:master Aug 7, 2019

1 of 2 checks passed

Travis CI - Pull Request Build Failed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:enum_variants_fix branch Aug 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.