Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for Rust 1.37 #4383

Merged
merged 2 commits into from Aug 14, 2019

Conversation

@phansch
Copy link
Member

commented Aug 14, 2019

Also updates the rest of the changelog wrt. to the latest releases and commit hashes.

changelog: none

Rendered

Update changelog for Rust 1.37
Also updates the rest of the changelog wrt. to the latest releases.
@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Unfortunately I didn't follow the changes around cargo/clippy integration too closely. Is #4175 supposed to be working with Rust 1.37 and to be included in the changelog? cargo clippy-preview still seems to be unstable, so I'm not sure.

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

r? @oli-obk or @flip1995
Manish doesn't have enough time currently, I think?

@Manishearth

This comment has been minimized.

Copy link
Member

commented Aug 14, 2019

Unfortunately I didn't follow the changes around cargo/clippy integration

None of that is finished, it's all under clippy-preview right now. Ignore it.

@bors r+

Feel free to write a beta changelog, btw, I usually do so that when doing a release the changelog is already there, and I just have to write the next one.

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

📌 Commit 171f307 has been approved by Manishearth

bors added a commit that referenced this pull request Aug 14, 2019
Auto merge of #4383 - phansch:update_changelog, r=Manishearth
Update changelog for Rust 1.37

Also updates the rest of the changelog wrt. to the latest releases and commit hashes.

[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog/CHANGELOG.md#rust-137)
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

⌛️ Testing commit 171f307 with merge 368af77...

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

💔 Test failed - checks-travis

@phansch

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

@bors r=Manishearth forgot the changelog: 😅

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

📌 Commit 171f307 has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

⌛️ Testing commit 171f307 with merge d829d9f...

bors added a commit that referenced this pull request Aug 14, 2019
Auto merge of #4383 - phansch:update_changelog, r=Manishearth
Update changelog for Rust 1.37

Also updates the rest of the changelog wrt. to the latest releases and commit hashes.

changelog: none

[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog/CHANGELOG.md#rust-137)
@bors

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing d829d9f to master...

@bors bors merged commit 171f307 into rust-lang:master Aug 14, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
homu Test successful
Details

@phansch phansch deleted the phansch:update_changelog branch Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.