Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for Rust 1.37 #4383

Merged
merged 2 commits into from Aug 14, 2019
Merged

Update changelog for Rust 1.37 #4383

merged 2 commits into from Aug 14, 2019

Conversation

@phansch
Copy link
Member

@phansch phansch commented Aug 14, 2019

Also updates the rest of the changelog wrt. to the latest releases and commit hashes.

changelog: none

Rendered

Also updates the rest of the changelog wrt. to the latest releases.
@phansch
Copy link
Member Author

@phansch phansch commented Aug 14, 2019

Unfortunately I didn't follow the changes around cargo/clippy integration too closely. Is #4175 supposed to be working with Rust 1.37 and to be included in the changelog? cargo clippy-preview still seems to be unstable, so I'm not sure.

Loading

@phansch
Copy link
Member Author

@phansch phansch commented Aug 14, 2019

r? @oli-obk or @flip1995
Manish doesn't have enough time currently, I think?

Loading

@Manishearth
Copy link
Member

@Manishearth Manishearth commented Aug 14, 2019

Unfortunately I didn't follow the changes around cargo/clippy integration

None of that is finished, it's all under clippy-preview right now. Ignore it.

@bors r+

Feel free to write a beta changelog, btw, I usually do so that when doing a release the changelog is already there, and I just have to write the next one.

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

📌 Commit 171f307 has been approved by Manishearth

Loading

bors added a commit that referenced this issue Aug 14, 2019
Update changelog for Rust 1.37

Also updates the rest of the changelog wrt. to the latest releases and commit hashes.

[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog/CHANGELOG.md#rust-137)
@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

Testing commit 171f307 with merge 368af77...

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

💔 Test failed - checks-travis

Loading

@phansch
Copy link
Member Author

@phansch phansch commented Aug 14, 2019

@bors r=Manishearth forgot the changelog: 😅

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

📌 Commit 171f307 has been approved by Manishearth

Loading

@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

Testing commit 171f307 with merge d829d9f...

Loading

bors added a commit that referenced this issue Aug 14, 2019
Update changelog for Rust 1.37

Also updates the rest of the changelog wrt. to the latest releases and commit hashes.

changelog: none

[Rendered](https://github.com/phansch/rust-clippy/blob/update_changelog/CHANGELOG.md#rust-137)
@bors
Copy link
Contributor

@bors bors commented Aug 14, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing d829d9f to master...

Loading

@bors bors merged commit 171f307 into rust-lang:master Aug 14, 2019
2 checks passed
Loading
@phansch phansch deleted the update_changelog branch Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants