Split up cmp_owned tests, add run-rustfix #4444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phansch
added
the
S-waiting-on-review
phansch
force-pushed
the
split_up_cmp_owned2
branch
from
016d043
to
b4cc6d7
Compare
Some of the cmp_owned tests emitted non-machine-applicable suggestions, so I moved them to `tests/ui/cmp_owned/without_suggestion.rs` and added `// run-rustfix` to the other half. cc rust-lang#3630
phansch
force-pushed
the
split_up_cmp_owned2
branch
from
b4cc6d7
to
9a0b598
Compare
flip1995
reviewed
Aug 26, 2019
phansch
commented
Aug 26, 2019
Co-Authored-By: Philipp Krones <hello@philkrones.com>
|
Thanks! @bors r+ |
|
|
bors
added a commit
that referenced
this pull request
Aug 26, 2019
Split up cmp_owned tests, add run-rustfix Some of the cmp_owned tests emitted non-machine-applicable suggestions, so I moved them to `tests/ui/cmp_owned/without_suggestion.rs` and added `// run-rustfix` to the other half. changelog: none cc #3630
|
@flip1995 thanks for doing all those reviews! |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Some of the cmp_owned tests emitted non-machine-applicable suggestions,
so I moved them to
tests/ui/cmp_owned/without_suggestion.rsand added// run-rustfixto the other half.changelog: none
cc #3630