Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up cmp_owned tests, add run-rustfix #4444

Merged
merged 2 commits into from Aug 26, 2019

Conversation

phansch
Copy link
Member

@phansch phansch commented Aug 24, 2019

Some of the cmp_owned tests emitted non-machine-applicable suggestions,
so I moved them to tests/ui/cmp_owned/without_suggestion.rs and added
// run-rustfix to the other half.

changelog: none

cc #3630

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 24, 2019
Some of the cmp_owned tests emitted non-machine-applicable suggestions,
so I moved them to `tests/ui/cmp_owned/without_suggestion.rs` and added
`// run-rustfix` to the other half.

cc rust-lang#3630
Co-Authored-By: Philipp Krones <hello@philkrones.com>
@flip1995
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Aug 26, 2019

📌 Commit 6d425a6 has been approved by flip1995

@bors
Copy link
Contributor

bors commented Aug 26, 2019

Testing commit 6d425a6 with merge 949b347...

bors added a commit that referenced this pull request Aug 26, 2019
Split up cmp_owned tests, add run-rustfix

Some of the cmp_owned tests emitted non-machine-applicable suggestions,
so I moved them to `tests/ui/cmp_owned/without_suggestion.rs` and added
`// run-rustfix` to the other half.

changelog: none

cc #3630
@phansch
Copy link
Member Author

phansch commented Aug 26, 2019

@flip1995 thanks for doing all those reviews!

@bors
Copy link
Contributor

bors commented Aug 26, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: flip1995
Pushing 949b347 to master...

@bors bors merged commit 6d425a6 into rust-lang:master Aug 26, 2019
@phansch phansch deleted the split_up_cmp_owned2 branch August 26, 2019 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants