-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing_const_for_fn false positive #4450
Conversation
We don't want to lint if any of the input parameters implement drop. (constant functions cannot evaluate destructors)
8d4dd77
to
1b18597
Compare
The lint now checks all arguments for types that implement |
Apparently I forgot to commit the updated .stderr, will do that later today 🤦♂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with stderr files.
@bors r=flip1995 |
📌 Commit 5e1fdf9 has been approved by |
Fix missing_const_for_fn false positive We don't want to lint if the type of the method implements drop. (constant functions cannot evaluate destructors) changelog: Fix `missing_const_for_fn` false positive Fixes #4449
☀️ Test successful - checks-travis, status-appveyor |
We don't want to lint if the type of the method implements drop.
(constant functions cannot evaluate destructors)
changelog: Fix
missing_const_for_fn
false positiveFixes #4449