Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cast_lossless false positive in impl const fn #4473

Merged
merged 1 commit into from Aug 30, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
@@ -88,6 +88,10 @@ pub fn in_constant(cx: &LateContext<'_, '_>, id: HirId) -> bool {
node: ItemKind::Fn(_, header, ..),
..
}) => header.constness == Constness::Const,
Node::ImplItem(&ImplItem {
node: ImplItemKind::Method(ref sig, _),
..
}) => sig.header.constness == Constness::Const,
_ => false,
}
}
@@ -32,3 +32,14 @@ fn main() {
const fn abc(input: f32) -> f64 {
input as f64
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: f32) -> f64 {
x as f64
}
}
}
@@ -32,3 +32,14 @@ fn main() {
const fn abc(input: f32) -> f64 {
input as f64
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: f32) -> f64 {
x as f64
}
}
}
@@ -34,3 +34,14 @@ fn main() {
const fn abc(input: u16) -> u32 {
input as u32
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: u32) -> u64 {
x as u64
}
}
}
@@ -34,3 +34,14 @@ fn main() {
const fn abc(input: u16) -> u32 {
input as u32
}

// Same as the above issue. We can't suggest `::from` in const fns in impls
mod cast_lossless_in_impl {
struct A;

impl A {
pub const fn convert(x: u32) -> u64 {
x as u64
}
}
}