Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clippy plugin #4714

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@msizanoen1
Copy link
Contributor

msizanoen1 commented Oct 22, 2019

This PR removes the clippy plugin, which is already deprecated and is causing the fmt_macros not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface

@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Oct 22, 2019

This won't remove the fmt_macros dependence? Also we didn't decide on how / when to remove the Clippy plugin interface. I think just nuking it is ok though, since the warning existed for a long time. cc #2783

ping @rust-lang/clippy thoughts on this?

@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Oct 22, 2019

Maybe this is better done in combination with #4650

@msizanoen1

This comment has been minimized.

Copy link
Contributor Author

msizanoen1 commented Oct 22, 2019

The error happens because clippy_lints was compiled for the host but fmt_macros is only available for the target. Plugins are compiled for the host so removing the plugin should fix the error.
The error is about cross compilation.

@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Oct 22, 2019

Ah ok, thanks for the clarification!

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Oct 22, 2019

We should definitely just remove it, yeah

@msizanoen1 msizanoen1 force-pushed the msizanoen1:remove-plugin branch from 2cacd17 to 592effc Oct 24, 2019
Copy link
Member

phansch left a comment

Maybe we should write a short announcement about removing this on inside-rust? With clear migration instructions, etc..

Apart from that I think we should finally remove this.

@flip1995

This comment has been minimized.

Copy link
Member

flip1995 commented Oct 24, 2019

I opened rust-lang/blog.rust-lang.org#435 for this. Feedback welcome.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Oct 24, 2019

☔️ The latest upstream changes (presumably #4650) made this pull request unmergeable. Please resolve the merge conflicts.

@msizanoen1 msizanoen1 force-pushed the msizanoen1:remove-plugin branch from 592effc to a127e14 Oct 24, 2019
@msizanoen1

This comment has been minimized.

Copy link
Contributor Author

msizanoen1 commented Nov 1, 2019

Now with rust-lang/rust#65698 merged, this PR is the only remaining roadblock for rust-lang/rust#62558

bors added a commit that referenced this pull request Nov 3, 2019
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)
bors added a commit that referenced this pull request Nov 3, 2019
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

📌 Commit a127e14 has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

⌛️ Testing commit a127e14 with merge 13578b5...

bors added a commit that referenced this pull request Nov 4, 2019
Remove clippy plugin

This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

💔 Test failed - checks-travis

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Nov 4, 2019

@bors r+ retry

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

📌 Commit a127e14 has been approved by Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

⌛️ Testing commit a127e14 with merge f14037b...

bors added a commit that referenced this pull request Nov 4, 2019
Remove clippy plugin

This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 4, 2019

💔 Test failed - checks-travis

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Nov 4, 2019

@lzutao

This comment has been minimized.

Copy link
Contributor

lzutao commented Nov 6, 2019

This can be merged.
@bors r=Manishearth

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 6, 2019

@lzutao: 🔑 Insufficient privileges: Not in reviewers

@Manishearth

This comment has been minimized.

Copy link
Member

Manishearth commented Nov 6, 2019

@bors r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 6, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 6, 2019

📌 Commit a127e14 has been approved by Manishearth

bors added a commit that referenced this pull request Nov 6, 2019
Remove clippy plugin

This PR removes the clippy plugin, which is already deprecated and is causing the `fmt_macros` not found error in rust-lang/rust#62558: rust-lang/rust#62558 (comment)

changelog: remove plugin interface
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 6, 2019

⌛️ Testing commit a127e14 with merge eae7b99...

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 6, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Manishearth
Pushing eae7b99 to master...

@bors bors merged commit a127e14 into rust-lang:master Nov 6, 2019
1 of 2 checks passed
1 of 2 checks passed
Travis CI - Pull Request Build Errored
Details
homu Test successful
Details
@msizanoen1 msizanoen1 deleted the msizanoen1:remove-plugin branch Nov 6, 2019
@msizanoen1 msizanoen1 mentioned this pull request Nov 6, 2019
bors added a commit to rust-lang/rust that referenced this pull request Nov 6, 2019
Update clippy

Update clippy to latest master to include rust-lang/rust-clippy#4714 which fixes #62558.

Close #62558
r? @Manishearth
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
flip1995 added a commit to flip1995/rust-clippy that referenced this pull request Nov 7, 2019
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes rust-lang#4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those rust-lang#4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
bors added a commit that referenced this pull request Nov 7, 2019
Fix Deprecated lints don't expand

### Move doc comments inside of declare_deprecated_lint macros so that they are picked up by lintlib.py

### fixes #4748

Unable to `cargo test` locally (I'm on NixOS, and keep getting errors that are similar to those #4714 might solve) but I have verified that all deprecated lints can now be expanded like other lints.

![2019-10-30_21:06:28](https://user-images.githubusercontent.com/1847524/67910501-5815de00-fb59-11e9-9fa2-91fe6a8b9bb9.png)

changelog: Show deprecated lints in lint documentation again
@msizanoen1 msizanoen1 mentioned this pull request Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.