Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix master deployment #4865

Merged
merged 1 commit into from Nov 30, 2019
Merged

Fix master deployment #4865

merged 1 commit into from Nov 30, 2019

Conversation

@phansch
Copy link
Member

phansch commented Nov 29, 2019

It was failing because it could not find .github/deploy_key.enc in the
current directory (./out). Switching to the previous directory should
fix the deployment and the master build.

Example Travis log: https://travis-ci.com/rust-lang/rust-clippy/jobs/261688169#L1900

changelog: none

cc @lzutao

It was failing because it could not find `.github/deploy_key.enc` in the
current directory (`./out`). Switching to the previous directory should
fix the deployment and the master build.
@llogiq

This comment has been minimized.

Copy link
Collaborator

llogiq commented Nov 30, 2019

@bors r+ looks good to me.

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 30, 2019

📌 Commit 403b9c6 has been approved by llogiq

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 30, 2019

⌛️ Testing commit 403b9c6 with merge e4d0997...

bors added a commit that referenced this pull request Nov 30, 2019
Fix master deployment

It was failing because it could not find `.github/deploy_key.enc` in the
current directory (`./out`). Switching to the previous directory should
fix the deployment and the master build.

Example Travis log: https://travis-ci.com/rust-lang/rust-clippy/jobs/261688169#L1900

changelog: none

cc @lzutao
@lzutao

This comment has been minimized.

Copy link
Contributor

lzutao commented Nov 30, 2019

I don't think it would work. We git add out side of the out dir.
Let's me think about this more and test it locally.
@bors r-

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 30, 2019

@lzutao: 🔑 Insufficient privileges: Not in reviewers

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Nov 30, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: llogiq
Pushing e4d0997 to master...

@bors bors merged commit 403b9c6 into rust-lang:master Nov 30, 2019
2 checks passed
2 checks passed
Travis CI - Pull Request Build Passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.