Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Use rustc's match_def_path #5452

Merged
merged 1 commit into from Apr 15, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 12, 2020

This replaces our match_def_path implementation with the rustc one.

Note that we can't just use it in all call sites because of the
&[&str] / &[Symbol] difference in Clippy/rustc.

changelog: none

@phansch phansch force-pushed the match_def_path_refactor branch from 68ce886 to 7813664 Compare Apr 12, 2020
@phansch phansch added the S-waiting-on-review label Apr 12, 2020
clippy_lints/src/utils/mod.rs Outdated Show resolved Hide resolved
This replaces our match_def_path implementation with the rustc one.

Note that we can't just use it in all call sites because of the
`&[&str]` / `&[Symbol]` difference in Clippy/rustc.
@phansch phansch force-pushed the match_def_path_refactor branch from 7813664 to 9ec95af Compare Apr 15, 2020
@phansch
Copy link
Member Author

phansch commented Apr 15, 2020

@bors r=matthiaskrgr

@bors
Copy link
Contributor

bors commented Apr 15, 2020

📌 Commit 9ec95af has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Apr 15, 2020

Testing commit 9ec95af with merge c6cc07a...

@bors
Copy link
Contributor

bors commented Apr 15, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing c6cc07a to master...

@bors bors merged commit c6cc07a into rust-lang:master Apr 15, 2020
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants