Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Use rustc's is_proc_macro_attr #5458

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 13, 2020

@phansch phansch added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Apr 13, 2020
@matthiaskrgr
Copy link
Member

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Apr 13, 2020

📌 Commit e47db67 has been approved by matthiaskrgr

@bors
Copy link
Contributor

bors commented Apr 13, 2020

⌛ Testing commit e47db67 with merge e07999a...

bors added a commit that referenced this pull request Apr 13, 2020
@bors
Copy link
Contributor

bors commented Apr 13, 2020

💔 Test failed - checks-action_remark_test

@phansch
Copy link
Member Author

phansch commented Apr 14, 2020

Not sure why the remark test failed - there are no logs?

@bors retry

@bors
Copy link
Contributor

bors commented Apr 14, 2020

⌛ Testing commit e47db67 with merge fc8714b...

bors added a commit that referenced this pull request Apr 14, 2020
@bors
Copy link
Contributor

bors commented Apr 14, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Member Author

phansch commented Apr 14, 2020

It doesn't fail for me locally although the failure happens on MacOS and I'm on Linux.. Let's try again 🤷

@bors retry

@bors
Copy link
Contributor

bors commented Apr 14, 2020

⌛ Testing commit e47db67 with merge aa08c39...

@bors
Copy link
Contributor

bors commented Apr 14, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: matthiaskrgr
Pushing aa08c39 to master...

@bors bors merged commit aa08c39 into rust-lang:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants