Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG.md for Rust 1.43 and 1.44 #5498

Merged
merged 4 commits into from Apr 23, 2020
Merged

Update CHANGELOG.md for Rust 1.43 and 1.44 #5498

merged 4 commits into from Apr 23, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Apr 20, 2020 •
edited

Rendered

changelog: none

@phansch phansch added the S-waiting-on-review label Apr 20, 2020
phansch
phansch reviewed Apr 20, 2020
View changes
CHANGELOG.md

[4ee1206...329923e](https://github.com/rust-lang/rust-clippy/compare/4ee1206...329923e)
[4ee1206...204bb9b](https://github.com/rust-lang/rust-clippy/compare/4ee1206...204bb9b)
Copy link
Member Author

@phansch phansch Apr 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff between those two is just a removal of the git2 dependency, so not worth a mention in the changelog: 329923e...204bb9b

flip1995
flip1995 reviewed Apr 20, 2020
View changes
Copy link
Member

@flip1995 flip1995 left a comment

LGTM. 2 NITs

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@phansch
Copy link
Member Author

@phansch phansch commented Apr 20, 2020 •
edited

Ohh, I should also mention that I didn't include the cargo clippy --fix changes, because they will still remain nightly only for a while. Let me know if I should include that here as well =)

(I think we should probably advertise that on the Inside Rust blog?)

@flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 20, 2020

I think we should include a line "Nightly only: cargo clippy --fix -Z unstable-options now fixes Clippy findings" (or something similar). I'd like people to discover the --fix arg more easily, so we can get feedback and fix potential bugs before stabilizing it. I think putting it in the changelog will help.

Advertising it in the Inside Rust blog sounds also good to me. @yaahc do you want to write the blog post, since you pushed this all the way through? :)

@phansch
Copy link
Member Author

@phansch phansch commented Apr 21, 2020

Added --fix to the top of Enhancements 👍

flip1995
flip1995 approved these changes Apr 21, 2020
View changes
Copy link
Member

@flip1995 flip1995 left a comment

Thanks! I will merge this when I do the rest of the release stuff on Thursday.

@yaahc
Copy link
Member

@yaahc yaahc commented Apr 21, 2020

Sure, I would be happy to write the blog post

@flip1995
Copy link
Member

@flip1995 flip1995 commented Apr 23, 2020

@bors r+

@bors
Copy link
Contributor

@bors bors commented Apr 23, 2020

📌 Commit 30c28a7 has been approved by flip1995

@bors
Copy link
Contributor

@bors bors commented Apr 23, 2020

⌛ Testing commit 30c28a7 with merge a609a9e...

@bors
Copy link
Contributor

@bors bors commented Apr 23, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a609a9e to master...

@bors bors merged commit a609a9e into rust-lang:master Apr 23, 2020
7 checks passed
@phansch phansch deleted the update_changelog branch Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flip1995 flip1995

Assignees
No one assigned
Labels
S-waiting-on-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phansch @flip1995 @yaahc @bors