-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for Rust 1.43 and 1.44 #5498
Conversation
|
||
[4ee1206...329923e](https://github.com/rust-lang/rust-clippy/compare/4ee1206...329923e) | ||
[4ee1206...204bb9b](https://github.com/rust-lang/rust-clippy/compare/4ee1206...204bb9b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff between those two is just a removal of the git2 dependency, so not worth a mention in the changelog: 329923e...204bb9b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 2 NITs
Ohh, I should also mention that I didn't include the (I think we should probably advertise that on the Inside Rust blog?) |
I think we should include a line "Nightly only: Advertising it in the Inside Rust blog sounds also good to me. @yaahc do you want to write the blog post, since you pushed this all the way through? :) |
Added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I will merge this when I do the rest of the release stuff on Thursday.
Sure, I would be happy to write the blog post |
@bors r+ |
📌 Commit 30c28a7 has been approved by |
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Rendered
changelog: none