default_trait_access: Fix wrong suggestion #5993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @phansch (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
taiki-e
commented
Aug 31, 2020
Comment on lines
-27
to
+35
| error: calling `GenericDerivedDefault<std::string::String>::default()` is more clear than this expression | ||
| --> $DIR/default_trait_access.rs:28:46 | ||
| error: calling `GenericDerivedDefault::default()` is more clear than this expression | ||
| --> $DIR/default_trait_access.rs:31:46 | ||
| | | ||
| LL | let s11: GenericDerivedDefault<String> = Default::default(); | ||
| | ^^^^^^^^^^^^^^^^^^ help: try: `GenericDerivedDefault<std::string::String>::default()` | ||
| | ^^^^^^^^^^^^^^^^^^ help: try: `GenericDerivedDefault::default()` |
There was a problem hiding this comment.
We already had a test for this, but it seems that the broken suggestion was missed.
adrianheine
approved these changes
Aug 31, 2020
|
@bors r+ thanks! |
|
📌 Commit 8b0aa6a has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5975 (comment)
Fixes #5975 Fixes #5990
changelog:
default_trait_access: fixed wrong suggestion