Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace some lazy_static usage with once_cell feature #6120

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 6, 2020

This replaces some lazy_static usage with SyncLazy of the unstable once_cell feature.

changelog: none

@rust-highfive
Copy link

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 6, 2020
@Manishearth
Copy link
Member

@bors r+

Neat!

@bors
Copy link
Contributor

bors commented Oct 6, 2020

📌 Commit 832d39f has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Oct 6, 2020

⌛ Testing commit 832d39f with merge e78c0c7...

bors added a commit that referenced this pull request Oct 6, 2020
Replace some lazy_static usage with once_cell feature

This replaces some `lazy_static` usage with [`SyncLazy`](https://doc.rust-lang.org/nightly/std/lazy/struct.SyncLazy.html) of the unstable `once_cell` feature.

changelog: none
@bors
Copy link
Contributor

bors commented Oct 6, 2020

💔 Test failed - checks-action_test

@phansch
Copy link
Member Author

phansch commented Oct 6, 2020

Will get to the failure later today, looks like a doctest was importing lazy_static

@phansch phansch force-pushed the replace-lazy-static branch from 832d39f to da57a16 Compare October 6, 2020 12:39
@phansch
Copy link
Member Author

phansch commented Oct 7, 2020

@bors r=Manishearth

@bors
Copy link
Contributor

bors commented Oct 7, 2020

📌 Commit da57a16 has been approved by Manishearth

@bors
Copy link
Contributor

bors commented Oct 7, 2020

⌛ Testing commit da57a16 with merge 2771918...

@bors
Copy link
Contributor

bors commented Oct 7, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 2771918 to master...

@bors bors merged commit 2771918 into rust-lang:master Oct 7, 2020
@phansch phansch deleted the replace-lazy-static branch October 12, 2020 14:23
phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 12, 2020
phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 12, 2020
phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 12, 2020
phansch added a commit to phansch/rust-clippy that referenced this pull request Oct 12, 2020
bors added a commit that referenced this pull request Oct 12, 2020
Remove lazy_static completely and use once_cell feature instead

Follow-up to #6120

This removes the last remaining `lazy_static` usages and replaces them with `SyncLazy` from the `once_cell` feature.

---

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants