Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lazy_static completely and use once_cell feature instead #6163

Merged
merged 3 commits into from Oct 12, 2020
Merged

Remove lazy_static completely and use once_cell feature instead #6163

merged 3 commits into from Oct 12, 2020

Conversation

phansch
Copy link
Member

@phansch phansch commented Oct 12, 2020 •
edited

Follow-up to #6120

This removes the last remaining lazy_static usages and replaces them with SyncLazy from the once_cell feature.

changelog: none

@rust-highfive
Copy link
Collaborator

r? @ebroto

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 12, 2020
@phansch phansch force-pushed the remove-one-lazy-static branch 2 times, most recently from d4551d8 to ffa3fee Compare October 12, 2020 15:53
@phansch phansch changed the title lintlist.rs: Replace lazy_static with once_cell Remove lazy_static completely and use once_cell feature instead Oct 12, 2020
@phansch
Copy link
Member Author

phansch commented Oct 12, 2020

The PR originally only included the first commit because I ran into trouble with SyncLazy in driver.rs. However, I got both working now and the PR now removes the lazy_static dependency completely 🎉

@flip1995
Copy link
Member

@bors r+

Thanks!

@bors
Copy link
Contributor

bors commented Oct 12, 2020

📌 Commit 7b3493c has been approved by flip1995

@bors
Copy link
Contributor

bors commented Oct 12, 2020

⌛ Testing commit 7b3493c with merge febd008...

@bors
Copy link
Contributor

bors commented Oct 12, 2020

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing febd008 to master...

@bors bors merged commit febd008 into rust-lang:master Oct 12, 2020
1 check passed
@phansch phansch deleted the remove-one-lazy-static branch October 13, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ebroto ebroto

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@phansch @rust-highfive @flip1995 @bors @ebroto