Change redundant_pattern_matching to also lint std::task::Poll
#6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ebroto (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
CDirkx
force-pushed
the
redundant-pattern-match-poll
branch
2 times, most recently
from
6d96043
to
e39c3fe
Compare
Suggest using utility methods `is_pending` and `is_ready`.
CDirkx
force-pushed
the
redundant-pattern-match-poll
branch
from
e39c3fe
to
5a83968
Compare
ebroto
approved these changes
Nov 24, 2020
|
@bors r+ Thanks! (and sorry for the delay in reviewing, I did not have much free time lately) |
|
📌 Commit 5a83968 has been approved by |
bors
added a commit
that referenced
this pull request
Nov 24, 2020
Change `redundant_pattern_matching` to also lint `std::task::Poll` `reduntant_pattern_matching` currently lints pattern matching on `Option` and `Result` where the `is_variant` utility methods could be used instead: `is_some`, `is_none`, `is_ok`, `is_err`. This PR extends this behaviour to `std::task::Poll`, suggesting the methods `is_pending` and `is_ready`. Motivation: The current description of `redundant_pattern_matching` mentions > It's more concise and clear to just use the proper utility function which in my mind applies to `Poll` as well.
|
💔 Test failed - checks-action_test |
ebroto
removed
the
S-waiting-on-review
|
@bors retry (changelog) |
|
If you agree with the similar reasoning I can create a PR to also add |
|
Yep, sounds good to me! |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
bors
added a commit
that referenced
this pull request
Nov 28, 2020
Enhance `redundant_pattern_matching` to also lint on `std::net::IpAddr` Follow-up to #6339 r? `@ebroto` (note: also contains a small cleanup of the other ui tests) changelog: Enhance [`redundant_pattern_matching`] to also lint on `std::net::IpAddr`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduntant_pattern_matchingcurrently lints pattern matching onOptionandResultwhere theis_variantutility methods could be used instead:is_some,is_none,is_ok,is_err. This PR extends this behaviour tostd::task::Poll, suggesting the methodsis_pendingandis_ready.Motivation: The current description of
redundant_pattern_matchingmentionswhich in my mind applies to
Pollas well.changelog: Enhance [
redundant_pattern_matching] to also lint onstd::task::Poll